Differential D27727

Remove empty/unused private classes on internal types
ClosedPublic
Actions

Authored by vkrause on Feb 28 2020, 7:51 PM.

Details

Reviewers
svuorela
Commits
R280:98f87482d4aa: GIT_SILENT Upgrade KF5 version to 5.68.0.
R280:10054afd8243: Remove empty/unused private classes on internal types
Summary

This avoids unnecessary allocations. This also un-exports QRCodeBarcode,
which is declared in a non-installed header file.

Diff Detail

Repository
R280 Prison
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Feb 28 2020, 7:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 28 2020, 7:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Feb 28 2020, 7:51 PM
svuorela accepted this revision.Mar 4 2020, 6:37 PM

These are leftovers from when all constructor was public.

This revision is now accepted and ready to land.Mar 4 2020, 6:37 PM
Closed by commit R280:10054afd8243: Remove empty/unused private classes on internal types (authored by vkrause). · Explain WhyMar 4 2020, 7:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76965

View Options

src/lib/code39barcode.h

Loading...
View Options

src/lib/code39barcode.cpp

Loading...
View Options

src/lib/code93barcode.h

Loading...
View Options

src/lib/code93barcode.cpp

Loading...
View Options

src/lib/datamatrixbarcode.h

Loading...
View Options

src/lib/datamatrixbarcode.cpp

Loading...
View Options

src/lib/qrcodebarcode.h

Loading...
View Options

src/lib/qrcodebarcode.cpp

Loading...