Properly look for the libphonenumber dependency

Authored by vkrause on Oct 21 2018, 9:41 AM.

Diff Detail

R20 Plasma Phone Components
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
vkrause requested review of this revision.Oct 21 2018, 9:41 AM
vkrause created this revision.
svuorela requested changes to this revision.Oct 21 2018, 9:57 AM

Very much an improvement. But we need a license file.


"the bsd license" is unfortunately a bit too unspecific, so copying over the full license text and placing it next to it is what we in general have done.


Doing something with targets would be nice.

This revision now requires changes to proceed.Oct 21 2018, 9:57 AM
vkrause added inline comments.

I am not finding any additional license terms at the source unfortunately. @dfaure This is your file from, what license is meant there exactly?

This seems copy/pasted from most of the attic cmake modules in ECM, which also say "the BSD license", with a reference to ECM's COPYING-CMAKE-SCRIPTS. Good enough?

vkrause updated this revision to Diff 44298.Oct 27 2018, 10:16 AM

Bring the find script up to ECM standards.

bshah accepted this revision.Oct 27 2018, 11:11 AM

Looks good to me.

svuorela accepted this revision.Oct 28 2018, 10:53 AM
This revision is now accepted and ready to land.Oct 28 2018, 10:53 AM
This revision was automatically updated to reflect the committed changes.