Add API to check whether a barcode is one- or two-dimensional
ClosedPublic
Actions

Authored by vkrause on Feb 28 2020, 8:55 PM.

Details

Reviewers

Commits

R280:3d4b8780a8d5: Add API to check whether a barcode is one- or two-dimensional

Summary

This matters for user code doing some more advanced layouting or size
computations, especially once we remove the hardcoded minimum sizes
in here for proper high dpi support.

Diff Detail

Repository

R280 Prison

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Feb 28 2020, 8:55 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 28 2020, 8:55 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

vkrause requested review of this revision.Feb 28 2020, 8:55 PM

Harbormaster completed remote builds in B23076: Diff 76661.Feb 28 2020, 8:55 PM

vkrause added a reviewer: svuorela.Mar 4 2020, 5:22 PM

I'm not sure I like the implementation. The current AbstractBarcode can also be implemented, at least theoretically, by software providing other barcodes that forever reason isn't available here. I have at least done that for some PoC ports of other things.

I suggest instead having a
enum class BarcodeDimensions { 1d, 2d, 3d, 4d } ;
perhaps with better names, and then just a barcodeDimensions() method on AbstractBarcode that can be switched over.

This revision now requires changes to proceed.Mar 4 2020, 6:37 PM

Alternative implementation for the barcode dimension API.

Harbormaster completed remote builds in B23383: Diff 77128.Mar 6 2020, 5:42 PM

thanks.

This revision is now accepted and ready to land.Mar 6 2020, 6:30 PM

Rebase and bump version number to 5.69.

Harbormaster completed remote builds in B23690: Diff 77607.Mar 14 2020, 10:05 AM

Closed by commit R280:3d4b8780a8d5: Add API to check whether a barcode is one- or two-dimensional (authored by vkrause). · Explain WhyMar 14 2020, 10:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (3 lines)
M			autotests/aztecbarcodetest.cpp (11 lines)
M			autotests/code128barcodetest.cpp (9 lines)
M			src/lib/CMakeLists.txt (10 lines)
M			src/lib/abstractbarcode.h (23 lines)
M			src/lib/abstractbarcode.cpp (14 lines)
M			src/lib/aztecbarcode.cpp (2 lines)
M			src/lib/code128barcode.cpp (2 lines)
M			src/lib/code39barcode.cpp (2 lines)
M			src/lib/code93barcode.cpp (2 lines)
M			src/lib/datamatrixbarcode.cpp (2 lines)
M			src/lib/qrcodebarcode.cpp (2 lines)
M			src/quick/barcodequickitem.h (10 lines)
M			src/quick/barcodequickitem.cpp (7 lines)
M			tests/barcode.qml (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76661	02be967		Feb 28 2020, 8:55 PM	★	★
Diff 2	77128	10054af	Alternative implementation for the barcode dimension API.	Mar 6 2020, 5:42 PM	★	★
Diff 3	77607	c83911e	Rebase and bump version number to 5.69.	Mar 14 2020, 10:05 AM	★	★
Diff 4	77609	c83911e	R280:3d4b8780a8d580a376d34e175aa3c4c7cfcb6658	Mar 14 2020, 10:51 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
7bd79848d52c	86eaa32cda9f	c83911e52faf	Volker Krause	Add API to check whether a barcode is one- or two-dimensional (Show More…)	Mar 14 2020, 10:01 AM

Add API to check whether a barcode is one- or two-dimensionalClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 77609

CMakeLists.txt

autotests/aztecbarcodetest.cpp

autotests/code128barcodetest.cpp

src/lib/CMakeLists.txt

src/lib/abstractbarcode.h

src/lib/abstractbarcode.cpp

src/lib/aztecbarcode.cpp

src/lib/code128barcode.cpp

src/lib/code39barcode.cpp

src/lib/code93barcode.cpp

src/lib/datamatrixbarcode.cpp

src/lib/qrcodebarcode.cpp

src/quick/barcodequickitem.h

src/quick/barcodequickitem.cpp

tests/barcode.qml

Add API to check whether a barcode is one- or two-dimensional
ClosedPublic
Actions

Revision Contents
Changeset List