sebas (Sebastian Kügler)
Plasma Hacker

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 8 2015, 2:33 PM (146 w, 2 d)
Availability
Available

Recent Activity

Fri, Feb 23

sebas committed R104:aeea618aeb1a: orientation -> rotation (authored by sebas).
orientation -> rotation
Fri, Feb 23, 11:28 AM
sebas committed R104:14cb695f3d7f: Merge branch 'master' into sebas/rotationplasmoid (authored by sebas).
Merge branch 'master' into sebas/rotationplasmoid
Fri, Feb 23, 11:28 AM
sebas committed R104:d6ec1341c169: Hook things up so that the screen rotates (authored by sebas).
Hook things up so that the screen rotates
Fri, Feb 23, 11:28 AM
sebas committed R104:c6d255139a52: Add QOrientationSensor to eventually rotate automtically (authored by sebas).
Add QOrientationSensor to eventually rotate automtically
Fri, Feb 23, 11:28 AM
sebas committed R104:c689f79eae92: Add xtouchscreen class (authored by sebas).
Add xtouchscreen class
Fri, Feb 23, 11:28 AM
sebas added a comment to D9414: Implement OSD to select action when unknown monitors is connected.

When landing, can you merge the whole branch into master, the history here is relevant and it will make continuing work on my kscreen kcm qmlification branch a lot easier. Thanks!

Fri, Feb 23, 10:46 AM · Plasma
sebas accepted D9414: Implement OSD to select action when unknown monitors is connected.
Fri, Feb 23, 10:32 AM · Plasma
sebas committed R110:7033859c3dd6: [kscreen-doctor] document output scaling in --help (authored by sebas).
[kscreen-doctor] document output scaling in --help
Fri, Feb 23, 9:44 AM
sebas committed R110:659d750b773b: allow setting rotation from kscreen-doctor (authored by sebas).
allow setting rotation from kscreen-doctor
Fri, Feb 23, 9:40 AM
sebas committed R104:cd3b350e0225: hide primary display combo when not supported (authored by sebas).
hide primary display combo when not supported
Fri, Feb 23, 8:57 AM
sebas closed D10723: hide primary display combo when not supported.
Fri, Feb 23, 8:57 AM · Plasma

Wed, Feb 21

sebas requested review of D10723: hide primary display combo when not supported.
Wed, Feb 21, 6:23 PM · Plasma

Wed, Jan 31

sebas added a comment to D9984: WIP: Add bookmarks runner.

That's what the "old" bookmarks runner was doing, it loaded the bookmarks from the file the browsers write out.

Wed, Jan 31, 11:18 AM · Plasma
sebas committed R169:93428bcdd007: fix typos in api docs (authored by sebas).
fix typos in api docs
Wed, Jan 31, 11:00 AM
sebas committed R169:9ca359064ffd: Fix typoes in api docs (authored by sebas).
Fix typoes in api docs
Wed, Jan 31, 10:59 AM

Tue, Jan 30

sebas accepted D10042: Parse EDID on the backend side.

One minor thing to fix, otherwise the idea + approach look fine to me. Thanks!

Tue, Jan 30, 3:34 PM · Plasma

Jan 24 2018

sebas committed R104:db1f05c3f380: add autorotate property (authored by sebas).
add autorotate property
Jan 24 2018, 9:52 AM

Jan 22 2018

sebas added a comment to D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager.

I like, getting rid of C++ code is always welcome.

Jan 22 2018, 12:54 PM · Plasma
sebas added a comment to D9506: milti-screen sleep fix.

Yeah, so could you abandon this phabricator review? It makes it harder to sift through reviews that actually are interesting...

Jan 22 2018, 12:35 PM · Plasma
sebas updated the task description for T7050: Privacy Software.
Jan 22 2018, 12:22 PM · Goal settings 2017
sebas updated the task description for T7050: Privacy Software.
Jan 22 2018, 12:21 PM · Goal settings 2017
sebas added a comment to D9414: Implement OSD to select action when unknown monitors is connected.

Please disregard the noise in this patch, sebas merged master into the dvratil/osd branch so I can't generate a proper diff against the base revision without the noise from master.

Jan 22 2018, 12:15 PM · Plasma
sebas added a comment to D9506: milti-screen sleep fix.

Alright, please abandon this patch then, it's definitely wrong.

Jan 22 2018, 8:45 AM · Plasma

Jan 19 2018

Restricted Application edited projects for D8652: Add supported transformations to OutputDevice, added: Plasma on Wayland; removed Plasma.

Dingdong?

Jan 19 2018, 9:46 AM · Plasma on Wayland, Frameworks
sebas requested changes to D9506: milti-screen sleep fix.

Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review.

Jan 19 2018, 9:33 AM · Plasma

Jan 18 2018

sebas requested changes to D9414: Implement OSD to select action when unknown monitors is connected.
Jan 18 2018, 4:09 PM · Plasma
sebas added a comment to D9414: Implement OSD to select action when unknown monitors is connected.

I've tested this branch, and it's looking quite good. On X11, it works as expected now after doing a few changes:

Jan 18 2018, 3:21 PM · Plasma
sebas committed R104:ceb8024880da: clean up osd more aggressively (authored by sebas).
clean up osd more aggressively
Jan 18 2018, 3:19 PM
sebas committed R104:0dfb1d77638d: Fix icons (authored by sebas).
Fix icons
Jan 18 2018, 3:19 PM
sebas committed R104:c0ed8ba83839: Fix typo in comment (authored by sebas).
Fix typo in comment
Jan 18 2018, 3:19 PM
sebas committed R104:0bb5dcec7b27: Merge branch 'master' into dvratil/osd (authored by sebas).
Merge branch 'master' into dvratil/osd
Jan 18 2018, 3:19 PM
sebas abandoned D3598: rework kscreen's OSD logic.

This branch is going to be merged as part of https://phabricator.kde.org/D9414

Jan 18 2018, 2:58 PM · Plasma

Jan 17 2018

sebas added a comment to D9909: Set raw EDID data for Wayland OutputDevices.

The idea when we designed the OutputManagement protocol was to pass the raw edid to libkscreen, I wonder when and why that changed? If it did, we'd need to parse the edid info somewhere in kwin and pass through individual values, can be done, but I'm still not sure why the idea had changed, and we'd also create a wart in the protocol since we changed our mind way too late.

Jan 17 2018, 11:13 AM · KWin
sebas added a comment to D9462: KCM: show scaled outputs correctly.

@dvratil that's much appreciated (I made that same mistake ;-))

Jan 17 2018, 11:07 AM · Plasma
sebas added a comment to D9464: KCM: add support for non-integer output scaling.

Also, any UI change needs screenshots attached how it looks with the change.

Jan 17 2018, 11:04 AM · Plasma
sebas added a comment to D9462: KCM: show scaled outputs correctly.

I agree with David, scaling the output makes the previewed "device" smaller.

Jan 17 2018, 10:58 AM · Plasma
sebas added a comment to D9414: Implement OSD to select action when unknown monitors is connected.

Will this OSD need any kind of styling? Or will we just use what was shown above in the screenshot?

Jan 17 2018, 8:02 AM · Plasma

Jan 16 2018

sebas added a comment to D9414: Implement OSD to select action when unknown monitors is connected.

I think OnScreenDisplay implies being non-interactive on Wayland

I could interact with the dialog on Wayland, so either it's not implied, or there's a bug in KWin :-)

Jan 16 2018, 4:27 PM · Plasma
sebas accepted D9908: Wayland: add support for output type detection.

Nice!

Jan 16 2018, 4:09 PM · Plasma
sebas accepted D9906: Wayland: don't update output configuration if there are no changes.

LGTM.

Jan 16 2018, 4:08 PM · Plasma
sebas accepted D9904: Wayland: don't share the same Config between backend and clients.

LGTM as well.

Jan 16 2018, 4:06 PM · Plasma
sebas accepted D9903: KDED: respond to output being completely removed.

Good catch!

Jan 16 2018, 4:00 PM · Plasma
sebas accepted D9463: XRandR: implement scaling support.

I'm not suitable to review the X11 bits in here, but since you are the former maintainer, I trust you on those.

Jan 16 2018, 3:59 PM · Plasma

Jan 9 2018

sebas accepted D9506: milti-screen sleep fix.

And I'm not sure they should. There's a difference between a monitor going to sleep and a configuration change of a multi screen setup.

Jan 9 2018, 11:39 AM · Plasma

Dec 14 2017

sebas accepted D9335: invalidate the runtime cache on install.
Dec 14 2017, 5:24 PM · Frameworks, Plasma

Dec 8 2017

sebas committed R290:3858faeec9dd: compile against Qt 5.7 (authored by sebas).
compile against Qt 5.7
Dec 8 2017, 10:22 AM
sebas updated subscribers of D8444: Define default Action when we plug unknown monitor.

@dvratil Good question. I actually have a branch that adds an OSD to kscreen. It's in sebas/osd right now and I haven't merged it since it behaves weirdly on Wayland (placement is not reliable). That should be the start. The plasmashell OSD is doesn't allow placing it on a specific screen (or both) which is something we'll want for this, since we're messing with screens right during that stage, and it's also not interactive. So we'd have to add quite some cases to plasmashell that are really only useful for kscreen. I'd start with that OSD and add interactivity and the selector for layouts.

Dec 8 2017, 10:09 AM · Plasma

Dec 5 2017

sebas committed R290:056fc67cecda: Fix up package indexing and add runtime caching (authored by sebas).
Fix up package indexing and add runtime caching
Dec 5 2017, 4:24 PM

Dec 4 2017

sebas committed R290:31dfd398d6c2: cleanups and clarity (authored by sebas).
cleanups and clarity
Dec 4 2017, 5:59 PM
sebas committed R290:0e0ada3efc2a: Don't create index in top-level dirs (authored by sebas).
Don't create index in top-level dirs
Dec 4 2017, 4:59 PM
sebas committed R290:f57988bfb6df: runtime caching only during first run (authored by sebas).
runtime caching only during first run
Dec 4 2017, 4:59 PM
sebas committed R290:06b7290541ae: move statics into packageloader (authored by sebas).
move statics into packageloader
Dec 4 2017, 4:59 PM
sebas committed R290:9dba4148a653: more sharing of kpluginindex string (authored by sebas).
more sharing of kpluginindex string
Dec 4 2017, 4:59 PM
sebas committed R290:d092ff671c38: Merge branch 'master' into sebas/runtimecache (authored by sebas).
Merge branch 'master' into sebas/runtimecache
Dec 4 2017, 4:59 PM
sebas committed R290:cb6d82baa7dd: some cleanups (authored by sebas).
some cleanups
Dec 4 2017, 4:59 PM

Dec 3 2017

sebas committed R290:bbef3c814c5e: actually zip (authored by sebas).
actually zip
Dec 3 2017, 3:43 PM
sebas committed R290:cb45a568c703: also index kwin, zip but don't for now (authored by sebas).
also index kwin, zip but don't for now
Dec 3 2017, 3:30 PM

Dec 2 2017

sebas committed R290:eef1889af10e: warning, no debug (authored by sebas).
warning, no debug
Dec 2 2017, 5:16 PM
sebas committed R290:e8882fe9d70c: add a runtime cache (authored by sebas).
add a runtime cache
Dec 2 2017, 5:05 PM
sebas accepted D9108: Remove implicit string casting.
Dec 2 2017, 2:41 PM · Frameworks, Plasma
sebas committed R290:32d4e8cd3e82: fix kpluginindex caching (authored by sebas).
fix kpluginindex caching
Dec 2 2017, 10:48 AM

Dec 1 2017

sebas committed R290:28df24e43b95: Improve error output (authored by sebas).
Improve error output
Dec 1 2017, 4:16 PM

Nov 20 2017

sebas added a comment to D8444: Define default Action when we plug unknown monitor.

@mlaurent What's your plan with this?

Nov 20 2017, 2:12 PM · Plasma

Nov 10 2017

sebas committed R119:8fea7fdaab1e: ui polish of formats kcm (authored by sebas).
ui polish of formats kcm
Nov 10 2017, 8:25 AM

Nov 9 2017

sebas committed R119:e1b3898c7e88: Change visible bell to visual bell (authored by sebas).
Change visible bell to visual bell
Nov 9 2017, 11:25 AM

Nov 7 2017

sebas added a comment to D8699: Support automatic screen rotation based on orientation sensor.

Or ... kwin has two modes: 1) kwin auto-rotates, tells kscreen that it doesn't do any other transforms, 2) kwin hands over to kscreen, not auto-rotating...

Nov 7 2017, 6:01 PM · Plasma
sebas accepted D8652: Add supported transformations to OutputDevice.
Nov 7 2017, 5:53 PM · Plasma on Wayland, Frameworks
sebas accepted D8645: [platforms/drm] Determine the supported transformation on a plane.
Nov 7 2017, 5:47 PM · Plasma
sebas added a comment to D8699: Support automatic screen rotation based on orientation sensor.

Ah, btw ... we have icons: They're in breeze-icons/applets/*/osd-rotate-{ccw,cw,flip,normal].svg

Nov 7 2017, 5:46 PM · Plasma
sebas accepted D8699: Support automatic screen rotation based on orientation sensor.

Code-wise, looks good.

Nov 7 2017, 5:40 PM · Plasma
sebas added a comment to T7317: Promo Sprint: Time and Place.

Updated my info for start of 2018. :)

Nov 7 2017, 7:21 AM · KDE Promo

Nov 2 2017

sebas committed R110:e6109ab94986: kwaylandconfig: autotest scale changed signal arrival (authored by sebas).
kwaylandconfig: autotest scale changed signal arrival
Nov 2 2017, 10:55 AM
sebas committed R110:057cefb97293: add scale and labels to output debug (authored by sebas).
add scale and labels to output debug
Nov 2 2017, 10:55 AM
sebas committed R110:ecf864ccd1e7: add debug << operator to config (authored by sebas).
add debug << operator to config
Nov 2 2017, 10:55 AM
sebas committed R110:1b95f2f38cb6: show in debug what the result is supposed to be (authored by sebas).
show in debug what the result is supposed to be
Nov 2 2017, 10:55 AM

Oct 31 2017

sebas added a comment to D8444: Define default Action when we plug unknown monitor.

Ow, I might add that we wanted to address a similar thing by providing a popup when a display is connected that asks the user what do do now, and then an action can be chosen. Maybe your time is spent better working on that feature, as we already agreed that this would make sense.

Oct 31 2017, 9:02 AM · Plasma
sebas added a comment to D8444: Define default Action when we plug unknown monitor.

Once you're done with the code, please also add screenshot so usability can have a look at it. I'm not sure we should add UI for this, the screen setup is already very complex and hard to understand. Perhaps a set of clear use-cases would make this clearer?

Oct 31 2017, 9:00 AM · Plasma

Oct 30 2017

sebas accepted D8390: Don't re-align outputs when QMLOutput in clone mode moves.

Please also merge into master.

Oct 30 2017, 12:31 PM · Plasma
sebas added a comment to D8391: Keep the unified QMLOutput always in center.

Please also merge into master.

Oct 30 2017, 12:30 PM · Plasma
sebas accepted D8391: Keep the unified QMLOutput always in center.
Oct 30 2017, 12:30 PM · Plasma
sebas accepted D8432: Use nullptr. Initialize pointer.
Oct 30 2017, 12:28 PM · Plasma

Oct 26 2017

sebas added a comment to T7317: Promo Sprint: Time and Place.
  1. Nijmegen, the Netherlands (preferred airport is AMS)
  2. Not in November, depends a little on the actual options, fairly flexible
  3. 2 - 3 days
Oct 26 2017, 11:55 AM · KDE Promo

Oct 10 2017

sebas committed R110:1c62a8262cfd: Allow setting mode by widthxheight@refreshrate (authored by sebas).
Allow setting mode by widthxheight@refreshrate
Oct 10 2017, 2:56 PM

Oct 6 2017

sebas accepted D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo.
Oct 6 2017, 12:44 PM · Plasma

Oct 4 2017

sebas committed R99:ae5454b41e4c: remove fontstest (authored by sebas).
remove fontstest
Oct 4 2017, 10:21 AM

Oct 2 2017

sebas added a comment to T7122: KDE needs to be convergent.

KDE needs to be convergent doesn't make sense. "KDE software needs to be convergent" would make sense. :-)

Oct 2 2017, 2:35 PM · Goal settings 2017
sebas accepted D8109: remove bogus test.
Oct 2 2017, 12:27 PM · Plasma

Sep 29 2017

sebas updated the task description for T7050: Privacy Software.
Sep 29 2017, 12:39 PM · Goal settings 2017
sebas added a comment to D8054: Show headset icons for devices identifying as "Headset" in Description.

Ah okay, I guess then keep this patch in, and ask for the breeze icon. :)

Sep 29 2017, 9:51 AM · Plasma
sebas added a comment to D8054: Show headset icons for devices identifying as "Headset" in Description.

Perhaps move the conditional to the end, so it is taken if there's nothing else, that's making "surer" that nothing that currently works is changed, and at the same time, request a headset icon for breeze?

Sep 29 2017, 9:48 AM · Plasma
sebas added a comment to D8054: Show headset icons for devices identifying as "Headset" in Description.

Where is the headset icon? I can't see it in breeze...

Sep 29 2017, 9:43 AM · Plasma

Sep 25 2017

sebas updated the task description for T7050: Privacy Software.
Sep 25 2017, 1:09 PM · Goal settings 2017
sebas updated the task description for T7050: Privacy Software.
Sep 25 2017, 1:06 PM · Goal settings 2017

Sep 22 2017

sebas added a comment to D7934: Add KCM for adjusting QtQuick Rendering in Plasma.

Thinking of it, wouldn't it make total sense to have this as a QtQuick-only KCM, i.e. using KQuickAddons::ConfigModule?

Sep 22 2017, 12:55 PM · Plasma
sebas updated the task description for T7050: Privacy Software.
Sep 22 2017, 12:19 PM · Goal settings 2017
sebas updated the task description for T7050: Privacy Software.
Sep 22 2017, 12:03 PM · Goal settings 2017
sebas updated the task description for T7050: Privacy Software.
Sep 22 2017, 11:59 AM · Goal settings 2017
sebas updated the task description for T7050: Privacy Software.
Sep 22 2017, 11:46 AM · Goal settings 2017
sebas updated the task description for T7050: Privacy Software.
Sep 22 2017, 11:37 AM · Goal settings 2017
sebas updated the task description for T7050: Privacy Software.
Sep 22 2017, 10:52 AM · Goal settings 2017