- User Since
- May 8 2015, 2:33 PM (206 w, 6 d)
Jan 21 2019
Jan 5 2019
Nov 5 2018
Apr 12 2018
Mar 14 2018
Mar 13 2018
Plasma/Wayland supports this, I've got a prototype plasmoid which allows to autorotate on X. Needs a bit more polishing and can be offered separately then.
Mar 12 2018
In principle yes, but the applet should of course react suitably to these constraints. A config option for this seems to duplicate the concept of constraints (which are indeed determined by the containment.)
Mar 7 2018
Mar 1 2018
I second that the icon should be made red, this mitigates the visibility issue and makes it consistent with the disconnected ethernet icon. @andreask, can you make this change?
Feb 28 2018
- clean up now-dead code
OsdManager::showActionSelector() will delete existing OSDs before showing a new one, so we won't create multiple OSDs. That's arguably not as nice as tracking if it's already shown, but I think I'd rather avoid the added complexity of adding a check if it's already there, if that's OK from your POV.
Feb 27 2018
Feb 23 2018
When landing, can you merge the whole branch into master, the history here is relevant and it will make continuing work on my kscreen kcm qmlification branch a lot easier. Thanks!
Feb 21 2018
Jan 31 2018
That's what the "old" bookmarks runner was doing, it loaded the bookmarks from the file the browsers write out.
Jan 30 2018
One minor thing to fix, otherwise the idea + approach look fine to me. Thanks!
Jan 24 2018
Jan 22 2018
I like, getting rid of C++ code is always welcome.
Yeah, so could you abandon this phabricator review? It makes it harder to sift through reviews that actually are interesting...
Alright, please abandon this patch then, it's definitely wrong.
Jan 19 2018
Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review.
Jan 18 2018
I've tested this branch, and it's looking quite good. On X11, it works as expected now after doing a few changes:
This branch is going to be merged as part of https://phabricator.kde.org/D9414
Jan 17 2018
The idea when we designed the OutputManagement protocol was to pass the raw edid to libkscreen, I wonder when and why that changed? If it did, we'd need to parse the edid info somewhere in kwin and pass through individual values, can be done, but I'm still not sure why the idea had changed, and we'd also create a wart in the protocol since we changed our mind way too late.
@dvratil that's much appreciated (I made that same mistake ;-))
Also, any UI change needs screenshots attached how it looks with the change.
I agree with David, scaling the output makes the previewed "device" smaller.
Jan 16 2018
LGTM as well.
I'm not suitable to review the X11 bits in here, but since you are the former maintainer, I trust you on those.
Jan 9 2018
And I'm not sure they should. There's a difference between a monitor going to sleep and a configuration change of a multi screen setup.