option to force FolderView icon-only presentation
AbandonedPublic

Authored by mvourlakos on Mar 11 2018, 12:53 AM.

Details

Reviewers
mart
hein
Group Reviewers
Plasma
Summary

--when a FolderView applet is located in panel, there
is the chance that the user wants to always remain
in icon-only presentation and never switch to
FullRepresentation
--update also row numbers in Icon Config Dialog in order
to be consistent to the new added option

BUG: 379888

Test Plan

disable option and check that everything works as accepted,
enable option in the panel and resize the panel to check
that FolderView icon appearance remains at all cases

Diff Detail

Repository
R119 Plasma Desktop
Branch
alwaysShowAsIcon
Lint
No Linters Available
Unit
No Unit Test Coverage
mvourlakos created this revision.Mar 11 2018, 12:53 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 11 2018, 12:53 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mvourlakos requested review of this revision.Mar 11 2018, 12:53 AM
hein added a reviewer: mart.Mar 12 2018, 9:37 AM
hein added a subscriber: hein.

Hmm I don't like the approach about putting this into individual applets - I think the containment should force constraints on the applets instead, and the applets need to follow the constraints. That's more Plasma-idiomatic to me. Marco?

broulik added inline comments.
containments/desktop/package/contents/ui/ConfigIcons.qml
155

"Always show as icon" or something like that?

sebas added a subscriber: sebas.Mar 12 2018, 9:39 AM

In principle yes, but the applet should of course react suitably to these constraints. A config option for this seems to duplicate the concept of constraints (which are indeed determined by the containment.)

Please read also: https://bugs.kde.org/show_bug.cgi?id=379888 why I proposed this.

The issue appeared from Latte Dock. When the user uses the parabolic effect and the FolderView is animated then somewhere in the middle of the animation it changes from icon to FullRepresentation and vice versa. In the bug report I proposed that this applet should respect at least the user-set panel icon-size in order to not change to FullRepresentation for values lower than the user set one.

So if the user has set Panel Icon Size:256px then the applet shouldnt change to FullRepresentation for values lower than that.
But @hein proposed that this isnt valid for the specific applet because some users might want to change to FullRepresentation earlier e.g. at sidebars.

So after that discussion I implemented a user choice for this...

I think the containment should force constraints on the applets instead, and the applets need to follow the constraints.

I dont have any problem to update the code if you can propose me an approach that fixes the Latte issue and preserves the plasma design.

A config option for this seems to duplicate the concept of constraints (which are indeed determined by the containment.)

to which constraints are you refering?

mart added a comment.Mar 13 2018, 12:09 PM

Shouldn't the quick launch applet cover this use case?

In D11220#224622, @mart wrote:

Shouldn't the quick launch applet cover this use case?

The quick launch applet can show folder contents or activities-pinned documents?

mvourlakos updated this revision to Diff 29439.Mar 13 2018, 9:38 PM
  • update semantics based on feedback
mvourlakos marked an inline comment as done.Mar 13 2018, 9:39 PM

settings window looks like:

In D11220#223836, @hein wrote:

Hmm I don't like the approach about putting this into individual applets - I think the containment should force constraints on the applets instead, and the applets need to follow the constraints. That's more Plasma-idiomatic to me. Marco?

what containment constraint can block an applet to go to FullRepresentation?
how do you imagine this to work?

mart added a reviewer: hein.Mar 23 2018, 1:17 PM

i don't see much use case for it, but...
Eike, i think the final word would be up to you, what do you think about it?

hein added a comment.Mar 24 2018, 11:59 AM

I really think this is ugly and don't want it :/

If it's the only way to end this debate, could you instead implement the patch that uses the icon size setting as switch threshold?

In D11220#232803, @hein wrote:

If it's the only way to end this debate, could you instead implement the patch that uses the icon size setting as switch threshold?

I created the following: https://phabricator.kde.org/D11651

mvourlakos abandoned this revision.Mar 25 2018, 8:38 AM

can be closed because https://phabricator.kde.org/D11651 was accepted...