| schmeisser |
| Plasma |
The URL validation regex excluded local IPs. This seems unnecessary
limiting, as it makes it very hard to reach perfectly valid local
webservers (often found it smart homes, for example).
This patch removes this restriction, allowing me to reach some lights,
my NAS and a bunch of other local servers from Angelfish.
Other webbrowsers do not restrict this, and it's unclear to me from
looking at the source why Angelfish should.
Surfed to my local webservers, they now work.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
this looks good, I don't know why local IPs were excluded. I assume this was just a copy paste error as this regex was maybe intended for a different use case originally? @jbbgameich might know more
Note that local hostnames are also excluded, and IMO that's also not helpful. My weekend-regexp-foo isn't sufficient to fix this right now, perhaps someone wants to give this a try?