milti-screen sleep fix
AbandonedPublic

Authored by McPain on Dec 26 2017, 1:40 PM.

Details

Reviewers
sebas
drosca
Summary

BUG: 379474

Diff Detail

Repository
R110 KScreen Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
McPain created this revision.Dec 26 2017, 1:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 26 2017, 1:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Dec 26 2017, 1:40 PM
McPain planned changes to this revision.Dec 29 2017, 12:16 PM

UPD:
As the secondary monitor switches off, windows on it doesn't move to the primary

sebas accepted this revision.Jan 9 2018, 11:39 AM

And I'm not sure they should. There's a difference between a monitor going to sleep and a configuration change of a multi screen setup.

Can you please merge this quickly? I'd like to give it some real-world exposure, we can always revisit this patch if it turns out to cause more problems than it solves.

McPain added a comment.Jan 9 2018, 1:33 PM
In D9506#188118, @sebas wrote:

And I'm not sure they should. There's a difference between a monitor going to sleep and a configuration change of a multi screen setup.

Can you please merge this quickly? I'd like to give it some real-world exposure, we can always revisit this patch if it turns out to cause more problems than it solves.

I haven't any permissions to commit.
This patch causes a problem: configuration does not change on unplugging monitor from powerline or switching it off.

@McPain can you provide some debug info from qCDebug(KSCREEN_XRANDR), i don't have multi screen setup but we can make better fix.

@McPain can you provide some debug info from qCDebug(KSCREEN_XRANDR), i don't have multi screen setup but we can make better fix.

https://pastebin.com/5gkn1qJU Standby
https://pastebin.com/7SnM0sc3 Shutdown

zerg added a subscriber: zerg.Jan 10 2018, 2:55 PM

According debug info "if (info.isNull())" may be always false and "case true:" never break.

I noticed that "shutdown" sequence is not the same as "standby" one.
Shutdown for secondary:
disconnect -> remove crtc -> connect -> assign crtc

Standby for secondary:
disconnect -> connect (why?) -> remove crtc -> assign crtc

sebas requested changes to this revision.Jan 19 2018, 9:33 AM

Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review.

McPain added a comment.EditedJan 19 2018, 10:44 AM
In D9506#193271, @sebas wrote:

Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review.

Yesterday I noticed that this bug is not always reproducible. See latest comment in the bug

UPD: two AOC's monitors cannot go sleeping

sebas added a comment.Jan 22 2018, 8:45 AM

Alright, please abandon this patch then, it's definitely wrong.

UPD:
I found monitor combination that makes KScreen works: AOC(hdmi)-iiyama(D-SUB)
If I swap monitors, KSCeen doesn't work (noticed it past friday evening)

Yeah, so could you abandon this phabricator review? It makes it harder to sift through reviews that actually are interesting...

McPain abandoned this revision.Jan 23 2018, 9:43 AM