BUG: 379474
Diff Detail
- Repository
- R110 KScreen Library
- Lint
Lint Skipped - Unit
Unit Tests Skipped
UPD:
As the secondary monitor switches off, windows on it doesn't move to the primary
And I'm not sure they should. There's a difference between a monitor going to sleep and a configuration change of a multi screen setup.
Can you please merge this quickly? I'd like to give it some real-world exposure, we can always revisit this patch if it turns out to cause more problems than it solves.
I haven't any permissions to commit.
This patch causes a problem: configuration does not change on unplugging monitor from powerline or switching it off.
@McPain can you provide some debug info from qCDebug(KSCREEN_XRANDR), i don't have multi screen setup but we can make better fix.
According debug info "if (info.isNull())" may be always false and "case true:" never break.
I noticed that "shutdown" sequence is not the same as "standby" one.
Shutdown for secondary:
disconnect -> remove crtc -> connect -> assign crtc
Standby for secondary:
disconnect -> connect (why?) -> remove crtc -> assign crtc
Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review.
Yesterday I noticed that this bug is not always reproducible. See latest comment in the bug
UPD: two AOC's monitors cannot go sleeping
UPD:
I found monitor combination that makes KScreen works: AOC(hdmi)-iiyama(D-SUB)
If I swap monitors, KSCeen doesn't work (noticed it past friday evening)
Yeah, so could you abandon this phabricator review? It makes it harder to sift through reviews that actually are interesting...