WIP: Add bookmarks runner

Authored by broulik on Jan 19 2018, 4:38 PM.


Group Reviewers

This finds bookmarks by querying the browser which is a lot less fragile than poking the browser's database files manually.

Test Plan

Results are also a lot more sensible

One major disadvantage I just now realized is that when the browser isn't running it won't work :/

The DBus API was quite straight-forward to work with, perhaps "subtext" could be part of the struct, but then, usually you also have urls, and then you add a gazillion properties to the struct? I think we could have the xml and structs be installed by krunner somehow, so we don't end up with copies all over the place

Diff Detail

R856 Plasma Browser Integration
Lint Skipped
Unit Tests Skipped
broulik created this revision.Jan 19 2018, 4:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 19 2018, 4:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 19 2018, 4:38 PM
mart added a subscriber: mart.Jan 23 2018, 11:13 AM

the problem is when the browser isn't running

abetts added a subscriber: abetts.Jan 23 2018, 4:36 PM

I like this idea. Can the bookmark list be offloaded to a temp file while the browser isn't running?

sebas added a subscriber: sebas.Jan 31 2018, 11:18 AM

That's what the "old" bookmarks runner was doing, it loaded the bookmarks from the file the browsers write out.

broulik abandoned this revision.Mar 27 2018, 4:09 PM

Not really worth it given it cannot work when the browser isn't running (main usecase for using it) and if we add a caching mechanism we're basically doing the same as the old bookmarks runner. Also, the runner is now (will shortly be) out of process so the Qt Sqlite stuff shouldn't have that big of a crashy impact anymore.