The server can announce all supported transformations on an OutputDevice.
The rational for this change is a requirement recognized in KWin in
combination with KScreen: KScreen should not offer to transform a screen
in a way which KWin cannot support. This API can fill the need.
Details
- Reviewers
sebas davidedmundson - Group Reviewers
Frameworks KWin Plasma
Diff Detail
- Repository
- R127 KWayland
- Branch
- supported-transformations
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/client/protocols/outputdevice.xml | ||
---|---|---|
225 | enum="transform" | |
src/server/outputdevice_interface.cpp | ||
470 | we have the initial send which is all fine Then you've got this dynamically add them. Personally, I'd just make it a static and document that it must be sent before the first done() |
src/server/outputdevice_interface.cpp | ||
---|---|---|
470 | I'm not 100 % sure whether we can in KWin determine the supported rotations in all cases before the OutputDeviceInterface is fully setup. Thus I wanted to have a little bit of flexibility here. Also if we need it we can add a remove. If we go for a static approach, we cannot remove again. |
The comment about being static needs to be in the protocol xml too. Then this is good to go.
( though what's your reasoning for not just having the argument as a Wayland array ?)