Differential D29372

Taiwan: Use "zh_TW" language code
AbandonedPublic
Actions

Authored by weisi on May 3 2020, 12:33 AM.

Details

Reviewers
winterz
Summary

It was set to tw_zh which I think is a typo. According to Wikipedia,

zh-TW is the IETF language tag for the Chinese language as used in Taiwan

Also note that HK uses zh_HK and CN uses zh_CN.

Diff Detail

Repository
R175 KHolidays
Lint
Lint Skipped
Unit
Unit Tests Skipped
weisi created this revision.May 3 2020, 12:33 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 3 2020, 12:33 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
weisi requested review of this revision.May 3 2020, 12:33 AM
weisi added a reviewer: winterz.May 3 2020, 12:35 AM

Adding a reviewer to this diff. Thanks!

krop mentioned this in D29223: Update Taiwanese holidays.May 3 2020, 9:12 AM
krop added a subscriber: krop.

D29223 addresses the issue and needs review

nhiga added a subscriber: nhiga.May 3 2020, 1:45 PM

I would say that the file should also be renamed.

My comment from D29223:

The new file name follows the same naming scheme used by the PRC (mainland China) holiday file, holiday_cn_zh-cn (holiday_region_Language-Region). It is also less ambiguous because zh alone does not indicate the character set being used (i.e. Simplified Chinese or Traditional Chinese).

weisi added a comment.May 3 2020, 7:09 PM

I think the approach in D29223 (renaming the file also) is more preferred.

weisi abandoned this revision.May 6 2020, 2:34 PM

Closing this revision. Let's get D29223 in.

Revision Contents
Changeset List

PathPackages
Mholidays/plan2/holiday_tw_zh (4 lines)

Diff 81768

View Options

holidays/plan2/holiday_tw_zh

Loading...