libzip: Fix CRC checksum display
AbandonedPublic

Authored by nhiga on Apr 7 2019, 4:50 AM.

Details

Reviewers
rthomsen
Group Reviewers
Ark
Summary

When the first entry in a ZIP file is a directory, Ark will not show the CRC checksums of the files. Fix this bug by removing the !e->isDir() check. This will make Ark show CRC "0" for directories.

BUG: 406135

Test Plan

Create a ZIP file which has a directory as the first entry, and open it in Ark.

Diff Detail

Repository
R36 Ark
Lint
Lint Skipped
Unit
Unit Tests Skipped
nhiga created this revision.Apr 7 2019, 4:50 AM
Restricted Application added a subscriber: kde-utils-devel. ยท View Herald TranscriptApr 7 2019, 4:50 AM
nhiga requested review of this revision.Apr 7 2019, 4:50 AM

Thanks for submitting the patch.

Unfortunately, this is not the right way to fix this. The problem is that Ark uses the first entry in the archive to decide which columns to show. Since directories don't have checksums, the CRC column is not shown for the problematic archive. I'm working on a solution for this.

nhiga abandoned this revision.Apr 12 2019, 3:07 AM