Add support for cb7 comic book archives
ClosedPublic

Authored by nhiga on Fri, Aug 9, 2:34 AM.

Details

Test Plan

Open a cb7 file (e.g. Attachment 122002 from Bug 410696) using Okular and see if it works.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nhiga requested review of this revision.Fri, Aug 9, 2:34 AM
nhiga created this revision.
pino added a subscriber: pino.Fri, Aug 9, 6:55 AM

Please do not manually change translated keys in desktop files: there is an automatic system that takes care of them.

nhiga updated this revision to Diff 63392.Fri, Aug 9, 7:02 AM
broulik added a subscriber: broulik.Fri, Aug 9, 7:04 AM

Works well, thanks a lot! Let's wait for Okular maintainer approval.

generators/comicbook/okularApplication_comicbook.desktop
168

Yes, please only change the untranslated key (the ones without [language]), the rest is taken care by a script :)

nhiga abandoned this revision.Fri, Aug 9, 7:21 AM
nhiga updated this revision to Diff 63394.
nhiga marked an inline comment as done.
nhiga removed subscribers: broulik, pino.
pino added a comment.Fri, Aug 9, 7:47 AM

why did you abandon this?

nhiga reclaimed this revision.Fri, Aug 9, 7:59 AM
pino added a subscriber: pino.Fri, Aug 9, 8:13 AM
nhiga added a subscriber: broulik.Fri, Aug 9, 9:49 AM

Sorry for the mess, I accidentally changed the status and subscriber list.

aacid added a comment.Fri, Aug 9, 11:53 PM

Works well, thanks a lot! Let's wait for Okular maintainer approval.

If by maintainer you mean me, the code looks sane.

Now nhiga, can you give us your full name and email for git history?

nhiga added a comment.Sat, Aug 10, 1:58 AM

@aacid Please check your email. I noticed that your public key (0x3A6A4DB839EAA6D7) seems to have expired, but I used that key to encrypt my message anyway.

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Aug 10, 9:45 AM
Closed by commit R223:5a8d21d597e0: Add support for cb7 comic book archives (authored by Natsumi Higa <c822c4f23bca1ea6faac79e2@mail.在线>, committed by aacid). · Explain Why
This revision was automatically updated to reflect the committed changes.

Strange, GPG still marks the key as expired (on 2019-07-31). From this keyserver, I see that the key should expire on 2019-09-04, and I tried the following commands, but it still does not work:
gpg --keyserver hkp://pool.sks-keyservers.net --recv-keys 3A6A4DB839EAA6D7
gpg --import /tmp/aacid_new.asc (I manually copied the PGP PUBLIC KEY BLOCK from the link you provided and saved it as a file)