Differential D27419

Update Japanese holidays
ClosedPublic
Actions

Authored by nhiga on Feb 15 2020, 2:08 AM.

Details

Reviewers
dvratil
winterz
krop
Commits
R175:263bc0f2d601: Update Japanese holidays
R175:1f9332f8f322: Update Japanese holidays
Summary

This patch is purely cosmetic since the predicted Vernal and Autumnal Equinox Days of 2021 are the same as the official announcement.
The source URLs in the comment section are now in HTTPS. (When using the HTTP version, a notice on "always-on" TLS of Cabinet Office Website will be displayed.)

Diff Detail

Repository
R175 KHolidays
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nhiga requested review of this revision.Feb 15 2020, 2:08 AM
nhiga created this revision.
krop accepted this revision.Feb 15 2020, 8:45 AM
This revision is now accepted and ready to land.Feb 15 2020, 8:45 AM
winterz accepted this revision.Feb 15 2020, 4:55 PM

I tested these changes locally. works

do you have commit access?

aacid added a subscriber: aacid.Feb 15 2020, 4:58 PM

No, she (i think) does not have commit access.

nhiga added a comment.Feb 16 2020, 4:15 AM
In D27419#612064, @winterz wrote:

I tested these changes locally. works

do you have commit access?

No, I do not have commit access. (I think commit access is only granted to active developers/contributors? )

Closed by commit R175:1f9332f8f322: Update Japanese holidays (authored by winterz). · Explain WhyFeb 16 2020, 3:30 PM
This revision was automatically updated to reflect the committed changes.
ltoscano added a subscriber: ltoscano.Feb 16 2020, 3:56 PM

Please revert and commit it with the correct authorship.

Revision Contents
Changeset List

Diff 75777

View Options

holidays/plan2/holiday_jp_en-us

Loading...
View Options

holidays/plan2/holiday_jp_ja

Loading...