When creating a RAR 5.0 archive, BLAKE2sp can be used instead of CRC32 for file checksums. This diff adds an entry for BLAKE2 file checksum.
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Ark - Commits
- R36:afdf8f2638c7: Display BLAKE2 file checksums for RAR files
Attached is a RAR 5.0 archive using BLAKE2sp file checksums.
Diff Detail
Diff Detail
- Repository
- R36 Ark
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Sorry for the delay. See the inline comment.
part/archivemodel.cpp | ||
---|---|---|
188 | I wonder if we could use a more descriptive string here. "BLAKE2" will be meaningless to most users. Maybe "Checksum" ? |
part/archivemodel.cpp | ||
---|---|---|
188 | I did not include the word "checksum" for BLAKE2 because I wanted to follow the example of "CRC". But it is true that CRC is more well-known than BLAKE2. Which of the following option is better in your opinion?
case CRC: return i18nc("CRC hash code", "CRC checksum"); case BLAKE2: return i18nc("BLAKE2 hash code", "BLAKE2 checksum");
case CRC: return i18nc("CRC hash code", "CRC"); case BLAKE2: return i18nc("BLAKE2 hash code", "BLAKE2 checksum"); |