i.Dark_Templar (Aleksei Nikiforov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 11 2017, 7:58 PM (70 w, 8 h)
Availability
Available

Recent Activity

Mon, Dec 10

i.Dark_Templar abandoned D17392: Fix checkDesktopFile function.

Abandoning this change in that case.

Mon, Dec 10, 9:05 PM · Frameworks

Thu, Dec 6

i.Dark_Templar added 1 commit(s) for D17392: Fix checkDesktopFile function: R241:16edef0dca46: Remove unused variable.
Thu, Dec 6, 7:42 PM · Frameworks
i.Dark_Templar added an edge to R241:16edef0dca46: Remove unused variable: D17392: Fix checkDesktopFile function.
Thu, Dec 6, 7:42 PM
i.Dark_Templar added a comment to D7260: System tray icon's context menu isn't updated properly in plasma/x11.

Any news on this bug and this change yet?

Thu, Dec 6, 7:18 PM · Plasma
i.Dark_Templar requested review of D17392: Fix checkDesktopFile function.
Thu, Dec 6, 7:16 PM · Frameworks

Mon, Nov 19

i.Dark_Templar added a comment to D16057: Fix opening URL's to help files.

After fixing bug 399274, the issue this change fixes becomes masked, but it still remains. It's hard to hit the issue now, maybe even impossible at the moment. But it might reappear later.

Mon, Nov 19, 8:25 PM · Documentation

Nov 6 2018

i.Dark_Templar added a comment to D16352: Contents items expanding issue.

Are there any obstacles remaining which prevent from merging these changes? It'd be great if you could review them and merge. If something still prevents the merge, I'd be glad to help fixing that.

Nov 6 2018, 8:35 PM · Documentation
i.Dark_Templar added a reviewer for D16352: Contents items expanding issue: ltoscano.
Nov 6 2018, 8:21 PM · Documentation

Oct 21 2018

i.Dark_Templar added a comment to D16352: Contents items expanding issue.

Oh, I see the source of confusion now. I think https://phabricator.kde.org/D16057 shouldn't link to bug 399275 since description of that bug is describing contents index items not expanding/collapsing if "double click" is selected if I understood it correctly.

Oct 21 2018, 2:57 PM · Documentation
i.Dark_Templar added a comment to D16352: Contents items expanding issue.

This is change for bug 399275.

Oct 21 2018, 2:23 PM · Documentation
i.Dark_Templar added a comment to D16352: Contents items expanding issue.

I've seen it. Linked change fixes different issue:

Oct 21 2018, 2:14 PM · Documentation
i.Dark_Templar requested review of D16352: Contents items expanding issue.
Oct 21 2018, 1:29 PM · Documentation

Oct 22 2017

i.Dark_Templar added a comment to D8413: Filelight crashes if readdir returns very long file name.

I'm not sure what part exactly is broken. It's just an incompatibility between linux (posix maybe?) file length limits and windows (ntfs) limits. I'm using default gentoo libc (sys-libs/glibc-, "GNU lib C library"). I've ran filelight under valgrind and didn't notice any warnings that glibc writes anything to wrong memory address. I've looked it up, and it looks like glibc allocates buffer large enough to hold more than NAME_MAX path (on my system it allocates 32768 bytes for whole DIRP, struct dirent and additional internal stuff). And it has a special structure field d_reclen to indicate the actual length of returned record. In my case d_reclen holds value 288 (for a filename 264 bytes long). It's not fully standard compatible, but I guess it helps to work around such system design incompatibilities and usually goes unnoticed by users.

Oct 22 2017, 12:19 PM
i.Dark_Templar created D8413: Filelight crashes if readdir returns very long file name.
Oct 22 2017, 8:04 AM

Sep 8 2017

i.Dark_Templar added a comment to D7260: System tray icon's context menu isn't updated properly in plasma/x11.

With this patch the "Bookmarks" menu in KWrite does no longer open (as if it were empty) with global menu enabled.

Sep 8 2017, 4:58 PM · Plasma

Aug 24 2017

i.Dark_Templar updated the diff for D7260: System tray icon's context menu isn't updated properly in plasma/x11.

Updated patch for plasma-workspace 5.10, I'm using it with 5.10.4, but it should apply to master too. I've tried adding appmenu panel to desktop, still works fine for me. A bit of clarification. I'm not sure it's important, but I'm currently using 'Oxygen' workspace theme and 'Air' desktop theme.

Aug 24 2017, 7:57 PM · Plasma

Aug 22 2017

i.Dark_Templar added a comment to D7260: System tray icon's context menu isn't updated properly in plasma/x11.

That's not entirely true. We do show the cached version, but also immediately call aboutToShow which will update the subtree. In theory at least :)

There's condition in function 'void DBusMenuImporter::slotAboutToShowDBusCallFinished(QDBusPendingCallWatcher *watcher)' around line 494:

if (needRefresh || menu->actions().isEmpty()) {

needRefresh is a value from dbus. Since another application already issued 'LayoutUpdate' event, needRefresh is false (it should be already refreshed, while it's actually not). And menu->actions() is not empty since it uses cached submenu (this is no longer true with this patch, this patch ensures that menu->actions() is empty).
I think another flag may be stored, for example ActionForId map may be expanded for that use case. But I don't see much difference in the end result.

Aug 22 2017, 9:08 PM · Plasma
i.Dark_Templar added a comment to D7260: System tray icon's context menu isn't updated properly in plasma/x11.

Current implementation is buggy. Cached menu items may be invalid: after 'LayoutUpdate' event updated menu all of it submenus are no longer valid (and thus cache contains invalid data) and should be updated. Menu itself is updated, but it's submenus are not. It's just usually happens that new submenu data is same as old submenu data, but in case it's not, you'll never get new submenu data and never see updated submenu. See example in menubugtest.tar.bz2 attached to linked bug (and description there).

Aug 22 2017, 4:54 PM · Plasma

Aug 15 2017

i.Dark_Templar added reviewers for D7260: System tray icon's context menu isn't updated properly in plasma/x11: Plasma, davidedmundson.
Aug 15 2017, 5:47 PM · Plasma

Aug 11 2017

i.Dark_Templar created D7260: System tray icon's context menu isn't updated properly in plasma/x11.
Aug 11 2017, 8:24 PM · Plasma