Fix checkDesktopFile function
AbandonedPublic

Authored by i.Dark_Templar on Thu, Dec 6, 7:16 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
Summary

Variable isLocal is no longer initialized anywhere.
Return function call which set it's value before while still discarding value returned by that function.
Also provide default value (false) for variable isLocal since function
items.mostLocalUrl(...) might not set a value to it if item is empty.

Alternatively, remains of isLocal variable and it's usage probably should be removed.

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
i.Dark_Templar created this revision.Thu, Dec 6, 7:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Dec 6, 7:16 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
i.Dark_Templar requested review of this revision.Thu, Dec 6, 7:16 PM
i.Dark_Templar abandoned this revision.Mon, Dec 10, 9:05 PM

Abandoning this change in that case.