kanji browser: add 'copy to clipboard' button
AbandonedPublic

Authored by i.Dark_Templar on Jun 6 2020, 6:25 PM.

Details

Reviewers
yurchor
mlaurent
Group Reviewers
KDE Edu
Summary

When looking for kanji in "search for kanji" window, it's possible to easily copy resulting kanji string with single button click.
It's also possible to copy kanji and it's meanings from main window.
But in kanji browser mode it's not intuitively obvious that user may copy kanji by selecting big image of kanji with line numbers printed on it and copying.
This change makes copying kanji from kanji browser more intuitive by providing a button for copying last viewed kanji.

Test Plan
  1. Open kanji browser, select any kanji, press new copy button
  2. Open some text editor, like kate, paste copied kanji and ensure that it's correct kanji
  3. Repeat steps 1 and 2 for different kanji few times

Diff Detail

Repository
R332 Kiten
Lint
Lint Skipped
Unit
Unit Tests Skipped
i.Dark_Templar created this revision.Jun 6 2020, 6:25 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJun 6 2020, 6:25 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
i.Dark_Templar requested review of this revision.Jun 6 2020, 6:25 PM

Actually, Phabricator is deprecated. It is recommended to use gitlab for the patches now.

https://invent.kde.org/education/kiten

Moreover, the "version" in kanjibrowserui.rc should be bumped to 2 to guarantee smooth updates.

Thank you. I'll update change and resubmit it to gitlab.

i.Dark_Templar abandoned this revision.Jun 6 2020, 6:36 PM