Differential D19993

Fix -Wreturn-type warning for jpeg version check
ClosedPublic
Actions

Authored by i.Dark_Templar on Mar 23 2019, 12:13 PM.

Details

Reviewers
ngraham
aacid
Commits
R260:170809762751: Fix -Wreturn-type warning for jpeg version check
Summary

See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87515

Test Plan

Build gwenview with '-Werror=return-type' in CFLAGS/CXXFLAGS.
Without this patch cmake call should fail if clean build directory is used.
With this patch applied build should succeed.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Gwenview. · View Herald TranscriptMar 23 2019, 12:13 PM
i.Dark_Templar requested review of this revision.Mar 23 2019, 12:13 PM
aacid accepted this revision.Mar 23 2019, 5:03 PM

i'll land it in a minute

This revision is now accepted and ready to land.Mar 23 2019, 5:03 PM
Closed by commit R260:170809762751: Fix -Wreturn-type warning for jpeg version check (authored by i.Dark_Templar, committed by aacid). · Explain WhyMar 23 2019, 5:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlib/CMakeLists.txt (2 lines)

Diff 54630

View Options

lib/CMakeLists.txt

Loading...