kicker: add option to make root level icons visible
Needs ReviewPublic

Authored by i.Dark_Templar on Mar 17 2019, 3:45 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
VDG
Summary

In file applets/kicker/package/contents/config/main.xml an option 'showIconsRootLevel' is mentioned. It has following description:
"Whether to show icons on the root level of the menu."

This change provides implementation for this option.

Test Plan

Manual test:

  1. Change menu to 'classic menu' (kicker), notice root level menu items have no icons
  2. Open menu settings widget
  3. Notice new checkbox 'Show icons on the root level of the menu'
  4. Check that checkbox and hit 'Apply' button
  5. Root menu items should now have icons similar which look similar to icons in 'modern menu' (kickoff)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
i.Dark_Templar created this revision.Mar 17 2019, 3:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 17 2019, 3:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
i.Dark_Templar requested review of this revision.Mar 17 2019, 3:45 PM
ngraham added a subscriber: ngraham.

Screenshots are always appreciated for changes to the UI. :)

Attaching screenshot with current look of menu (or with disabled option) and new look with enabled option and also a configuration widget.

hein added a comment.Mar 17 2019, 4:28 PM

Kicker intentionally doesn't have icons on the root level to not conflict with the favorites column and reduce visual noise.

i.Dark_Templar added a comment.EditedMar 17 2019, 4:39 PM

Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it may be enabled if this change is applied. And in my opinion it looks more consistent in style with 'modern menu' since 'modern menu' has those icons enabled.

Edit: and it looks more consistent with menu editor which show those root level icons. It looks weird for me when menu editor shows those icons but menu does not.

GB_2 added a subscriber: GB_2.Tue, Apr 2, 1:56 PM

Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it may be enabled if this change is applied. And in my opinion it looks more consistent in style with 'modern menu' since 'modern menu' has those icons enabled.

Edit: and it looks more consistent with menu editor which show those root level icons. It looks weird for me when menu editor shows those icons but menu does not.

I would personally like to have this feature.