Am Donnerstag, 24. Februar 2022, 11:07:38 CET schrieb Phu Nguyen:

phunh added a comment.

KDiskFree and KDE Wallet Manager are listed on utils.k.o, they are also in

the utilities group on Invent, but their desktop files list only "System"
as their main category, so now they show up on only
https://apps.kde.org/system. Should their desktop files also list
"Utilities" in the "Categories" field?

I don't know how much sense this makes if switching to gitlab is on the roadmap.

Thanks for the reminder, this sadly got lost in my inbox.

Could you please push this change when it'd be convenient for you? I don't have permissions. Thanks.

So I finally found time to look at it. First, I would suggest to trigger archive.org to collect all pages before they are shut down.

This expression is different from the other one in that it has no choice on it, so I wonder if a simple startsWith(QLatin1String("./")) isn't enough here.

QStandardItemModel::clear() also removes the header data, this is not done here. This looks more like clearData(), which was introduced in 5.12.

Yes, I'm particularly bad at this currently. I see this mail, I'm just distracted by everything else. Please bear with me for the moment, I'll take care of this soonish.

please do a git commit and then "git format-patch -1" and send me the resulting file via mail, then I'll apply this.

Looks good to me so far. The size in the ui file is now much bitter than before, please check if that is really needed. Otherwise feel free to push.

I personally like it and it would often be helpful for my personal use, so I guess if noone complains just go for it.

Since noone else steps in, I'll put my module maintainer head on.

Dupe of D21514

Die Übersetzung passphrase=Kennwort gibt es auch in KGpg, daher füge

ich Rolf Eike Beer als Reviewer hinzu.

If it would be "move it out of extragear, where will we place it" I would say kdeutils is fine. But it seems to sit in KDE Applications for quite a while, so I'm unsure if moving it to another module does more confusion than benefit. After all, if you say it helps if it's in utils, I'll welcome it as it would fit IMHO. I'm just not convinced (yet?) that the move provides a benefit in itself.

use lambda as suggested by Milian

No, I was just looking at it. I could remove the QByteArray change and reduce it to online the x.remove() and "else if" parts.

The QByteArray was already created the same way, now the intermediate object is just cached. But even if that did not change anything it reduces the number of utf8 conversion as only those lines that actually match anything will be converted.