Differential D21514

MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet
ClosedPublic
Actions

Authored by dfaure on May 31 2019, 5:28 PM.

Details

Reviewers
mart
apol
broulik
ngraham
Commits
R858:a759ed533f8b: MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet
Summary

This file checks for controlRoot being undefined, everywhere else.

BUG: 408719
FIXED-IN: 5.60

Test Plan

qmlscene tests/testComboBox.qml showed
MobileTextActionsToolBar.qml:62: TypeError: Cannot read property 'selectedText' of null
MobileTextActionsToolBar.qml:70: TypeError: Cannot read property 'selectedText' of null
MobileTextActionsToolBar.qml:78: TypeError: Cannot read property 'canPaste' of null

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Branch
2019_fix_MobileTextActionsToolBar_warnings
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12303
Build 12321: arc lint + arc unit
dfaure created this revision.May 31 2019, 5:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 31 2019, 5:28 PM
dfaure requested review of this revision.May 31 2019, 5:28 PM
astippich added a subscriber: astippich.Jun 29 2019, 2:11 PM

+1, also fixes the warnings in Elisa

ngraham accepted this revision.Jun 30 2019, 5:47 PM
This revision is now accepted and ready to land.Jun 30 2019, 5:47 PM
ngraham edited the summary of this revision. (Show Details)Jun 30 2019, 5:48 PM
apol accepted this revision.Jun 30 2019, 7:19 PM
dfaure closed this revision.Jul 1 2019, 10:33 AM

Revision Contents
Changeset List

Diff 58962

View Options

org.kde.desktop/private/MobileTextActionsToolBar.qml

Loading...