base class function already does what we need
Needs ReviewPublic

Authored by schwarzer on Aug 14 2019, 12:13 AM.

Details

Reviewers
dakon
Summary

The base class here is QStandardItemModel, which already implements clear() the way we need it. Or am I missing something?

Diff Detail

Repository
R363 Print Manager
Lint
Lint Skipped
Unit
Unit Tests Skipped
schwarzer created this revision.Aug 14 2019, 12:13 AM
Restricted Application added a subscriber: kde-utils-devel. ยท View Herald TranscriptAug 14 2019, 12:13 AM
schwarzer requested review of this revision.Aug 14 2019, 12:13 AM
dakon added a comment.Dec 18 2019, 7:46 PM

QStandardItemModel::clear() also removes the header data, this is not done here. This looks more like clearData(), which was introduced in 5.12.