Differential D22908

avoid qml warnings when controlRoot is not set
AbandonedPublic
Actions

Authored by dakon on Aug 3 2019, 11:41 AM.

Details

Reviewers
ngraham
mart
apol
Group Reviewers
Plasma
Summary

When debugging a custom Qml application in KDevelop I'm spammed with these
messages otherwise:

file:///usr/lib64/qt5/qml/QtQuick/Controls.2/org.kde.desktop/private/MobileTextActionsToolBar.qml:62: TypeError: Cannot read property 'selectedText' of null
file:///usr/lib64/qt5/qml/QtQuick/Controls.2/org.kde.desktop/private/MobileTextActionsToolBar.qml:70: TypeError: Cannot read property 'selectedText' of null
file:///usr/lib64/qt5/qml/QtQuick/Controls.2/org.kde.desktop/private/MobileTextActionsToolBar.qml:78: TypeError: Cannot read property 'canPaste' of null
file:///usr/lib64/qt5/qml/QtQuick/Controls.2/org.kde.desktop/private/MobileTextActionsToolBar.qml:78: TypeError: Type error
file:///usr/lib64/qt5/qml/QtQuick/Controls.2/org.kde.desktop/private/MobileTextActionsToolBar.qml:70: TypeError: Type error
file:///usr/lib64/qt5/qml/QtQuick/Controls.2/org.kde.desktop/private/MobileTextActionsToolBar.qml:62: TypeError: Type error

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Lint Skipped
Unit
Unit Tests Skipped
dakon created this revision.Aug 3 2019, 11:41 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 3 2019, 11:41 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dakon requested review of this revision.Aug 3 2019, 11:41 AM
ngraham accepted this revision.Aug 4 2019, 6:04 PM
ngraham added reviewers: mart, Plasma.
ngraham added subscribers: mart, ngraham.

@mart, does this look correct to you?

This revision is now accepted and ready to land.Aug 4 2019, 6:04 PM
apol accepted this revision.Aug 5 2019, 12:50 AM
dakon abandoned this revision.Aug 14 2019, 7:45 PM

Dupe of D21514

Revision Contents
Changeset List

Diff 63022

View Options

org.kde.desktop/private/MobileTextActionsToolBar.qml

Loading...