optimize CMakeBuildDirChooser::buildDirSettings()

Authored by dakon on Feb 8 2019, 8:36 AM.

Description

optimize CMakeBuildDirChooser::buildDirSettings()

Summary:
-if we have a match for a key, no other key can match
-match the start of a new line as QByteArray instead of QString, most lines will
not match and all keys are plain ASCII, this saves a lot of needless
conversions and memory allocations
-modify the original line instead of doing a copy, the original one will not
be used again anyway.

Test Plan: Open and build a CMake-based project.

Reviewers: mwolff

Reviewed By: mwolff

Subscribers: mwolff, apol, kdevelop-devel

Tags: KDevelop

Differential Revision: https://phabricator.kde.org/D18857

Details

Committed
dakonFeb 21 2019, 9:06 PM
Reviewer
mwolff
Differential Revision
D18857: optimize CMakeBuildDirChooser::buildDirSettings()
Parents
R32:3c2725a67d3a: [Sessions Runner] Use icon name
Branches
Unknown
Tags
Unknown