Fix some compiler warnings
ClosedPublic

Authored by schwarzer on Fri, Aug 9, 12:23 PM.

Details

Reviewers
dakon
Summary

While looking for something else, I got rid of some of the warnings, the compiler gave me here.

Test Plan

Compiles.

Diff Detail

Repository
R363 Print Manager
Lint
Lint Skipped
Unit
Unit Tests Skipped
schwarzer created this revision.Fri, Aug 9, 12:23 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptFri, Aug 9, 12:23 PM
schwarzer requested review of this revision.Fri, Aug 9, 12:23 PM
dakon added a subscriber: dakon.Fri, Aug 9, 12:30 PM
dakon added inline comments.
add-printer/AddPrinter.cpp
36 ↗(On Diff #63400)

Can you initialize this directly in the class?

schwarzer added inline comments.Fri, Aug 9, 2:30 PM
add-printer/AddPrinter.cpp
36 ↗(On Diff #63400)

Of course. :)

schwarzer updated this revision to Diff 63417.Fri, Aug 9, 2:31 PM

init member in header

I think I updated to a new diff but it is not showing the new changes ... Any hint?

schwarzer updated this revision to Diff 63438.Fri, Aug 9, 5:21 PM

My bad, this should now be the right diff.

Any more complaints/suggestions? I do not know who would be a good assignee for print-manager since several people more or less sporadically work on it.

dakon accepted this revision.Wed, Aug 14, 7:47 PM

Since noone else steps in, I'll put my module maintainer head on.

This revision is now accepted and ready to land.Wed, Aug 14, 7:47 PM