umanovskis (Daniels Umanovskis)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Fri, Sep 20, 11:55 AM (3 w, 2 d)
Availability
Available

Recent Activity

Today

umanovskis added a comment to D24213: Add live conversions between numerical bases.

Ping - if this is satisfactory, I need someone's help to land.

Mon, Oct 14, 8:27 AM

Wed, Oct 9

umanovskis updated the diff for D24383: Display "executable" in info panel instead of "unknown".
  • Changed per review comments
Wed, Oct 9, 7:46 AM · Ark

Mon, Oct 7

umanovskis added a comment to D24213: Add live conversions between numerical bases.

The change in the ui file is pretty big because I removed the base controls from their previous layout and put them in a new one, which caused Qt Designer to output quite many changes as the number of layouts has changed. Seems to me like it's needed.

Mon, Oct 7, 11:54 AM
umanovskis added a comment to D24213: Add live conversions between numerical bases.

So much for touching unfamiliar QT types while not properly concentrating, ended up with some absurd code :)

Mon, Oct 7, 9:55 AM
umanovskis updated the diff for D24213: Add live conversions between numerical bases.

remove over-complicated conversions

Mon, Oct 7, 9:54 AM
umanovskis added inline comments to D24213: Add live conversions between numerical bases.
Mon, Oct 7, 7:59 AM
umanovskis updated the diff for D24213: Add live conversions between numerical bases.

minor fixes per above

Mon, Oct 7, 7:58 AM
umanovskis added a comment to D24213: Add live conversions between numerical bases.

@dakon would you agree with this revision? Doesn't seem like anyone else has feedback.

Mon, Oct 7, 7:40 AM
umanovskis added a reviewer for D24383: Display "executable" in info panel instead of "unknown": elvisangelaccio.
Mon, Oct 7, 7:38 AM · Ark

Thu, Oct 3

umanovskis added a comment to D24213: Add live conversions between numerical bases.

I'm glad it's not just me who has this as a major use case for calculator applications.

Thu, Oct 3, 1:28 PM
umanovskis updated the diff for D24213: Add live conversions between numerical bases.

Changed per suggestions, and changed UI slightly to prevent overflow

Thu, Oct 3, 1:27 PM
umanovskis added a reviewer for D24383: Display "executable" in info panel instead of "unknown": Ark.
Thu, Oct 3, 11:08 AM · Ark
umanovskis added a comment to D24383: Display "executable" in info panel instead of "unknown".

Before and after comparison.

Thu, Oct 3, 11:07 AM · Ark
umanovskis requested review of D24383: Display "executable" in info panel instead of "unknown".
Thu, Oct 3, 11:04 AM · Ark
umanovskis abandoned D24219: Reformat source code in kdelibs style.

There seems to be no consensus that that such reformats of old code are needed. Closing.

Thu, Oct 3, 7:54 AM

Tue, Oct 1

umanovskis added a comment to D24213: Add live conversions between numerical bases.

Ping on this one - any thoughts?

Tue, Oct 1, 11:15 AM

Thu, Sep 26

umanovskis updated the diff for D24219: Reformat source code in kdelibs style.

Fixed overzealous formatting

Thu, Sep 26, 7:34 AM

Wed, Sep 25

umanovskis added a comment to D24219: Reformat source code in kdelibs style.

On the git blame point, I've found git hyper-blame to be very useful for exactly this case: https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html

Wed, Sep 25, 8:44 PM
umanovskis updated the diff for D24219: Reformat source code in kdelibs style.

Changed to uncrustify

Wed, Sep 25, 8:05 PM
umanovskis added a comment to D24219: Reformat source code in kdelibs style.

Yeah, I also started by copying the style, but realized a reformat might be acceptable before I do more.

Wed, Sep 25, 8:04 PM
umanovskis added a comment to D24219: Reformat source code in kdelibs style.

I wanted to make some minor changes like removing the QT foreach from KCalc, but then it seemed prudent to first reformat the source according to KDE style. The vast majority of this diff consists of moved opening braces, and tabs replaced by spaces.

Wed, Sep 25, 12:15 PM
umanovskis requested review of D24219: Reformat source code in kdelibs style.
Wed, Sep 25, 12:12 PM
umanovskis added a comment to D24213: Add live conversions between numerical bases.

First I'm looking for UI feedback. My current attempt looks like this:

Wed, Sep 25, 9:18 AM
umanovskis requested review of D24213: Add live conversions between numerical bases.
Wed, Sep 25, 9:10 AM

Tue, Sep 24

umanovskis added a comment to D24110: Enable removing multiple devices at once.

Thanks! Would you land this for me?

Tue, Sep 24, 1:46 PM · Plasma
umanovskis added inline comments to D24110: Enable removing multiple devices at once.
Tue, Sep 24, 10:20 AM · Plasma
umanovskis updated the diff for D24110: Enable removing multiple devices at once.
  • Handle all device deletion in one function, reducing duplication
Tue, Sep 24, 10:18 AM · Plasma

Mon, Sep 23

umanovskis added a comment to D24110: Enable removing multiple devices at once.

Rebased and adapted per suggestion above.

Mon, Sep 23, 11:05 AM · Plasma
umanovskis updated the diff for D24110: Enable removing multiple devices at once.
  • Update message box to a more user-friendly format
Mon, Sep 23, 11:04 AM · Plasma

Fri, Sep 20

umanovskis added inline comments to D24110: Enable removing multiple devices at once.
Fri, Sep 20, 3:01 PM · Plasma
umanovskis added a comment to D24110: Enable removing multiple devices at once.

Screenshot of the new action:

Fri, Sep 20, 12:07 PM · Plasma
umanovskis requested review of D24110: Enable removing multiple devices at once.
Fri, Sep 20, 12:05 PM · Plasma