- User Since
- Fri, Sep 20, 11:55 AM (3 w, 2 d)
Ping - if this is satisfactory, I need someone's help to land.
Wed, Oct 9
- Changed per review comments
Mon, Oct 7
The change in the ui file is pretty big because I removed the base controls from their previous layout and put them in a new one, which caused Qt Designer to output quite many changes as the number of layouts has changed. Seems to me like it's needed.
So much for touching unfamiliar QT types while not properly concentrating, ended up with some absurd code :)
remove over-complicated conversions
minor fixes per above
@dakon would you agree with this revision? Doesn't seem like anyone else has feedback.
Thu, Oct 3
I'm glad it's not just me who has this as a major use case for calculator applications.
Changed per suggestions, and changed UI slightly to prevent overflow
Before and after comparison.
There seems to be no consensus that that such reformats of old code are needed. Closing.
Tue, Oct 1
Ping on this one - any thoughts?
Thu, Sep 26
Fixed overzealous formatting
Wed, Sep 25
On the git blame point, I've found git hyper-blame to be very useful for exactly this case: https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html
Changed to uncrustify
Yeah, I also started by copying the style, but realized a reformat might be acceptable before I do more.
I wanted to make some minor changes like removing the QT foreach from KCalc, but then it seemed prudent to first reformat the source according to KDE style. The vast majority of this diff consists of moved opening braces, and tabs replaced by spaces.
First I'm looking for UI feedback. My current attempt looks like this:
Tue, Sep 24
Thanks! Would you land this for me?
- Handle all device deletion in one function, reducing duplication
Mon, Sep 23
Rebased and adapted per suggestion above.
- Update message box to a more user-friendly format
Fri, Sep 20
Screenshot of the new action: