alnikiforov (Aleksei Nikiforov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2019, 7:13 AM (32 w, 11 h)
Availability
Available

Recent Activity

Fri, May 22

alnikiforov added a comment to D28337: Fix unmounting during preview generation.
Solid only sends broadcast notification and doesn't wait for any reply, thus unmounting may fail due to preview jobs not stopping in time.

That points to a solid shortcoming worth fixing. Adding a wait for apps to ask solid to wait or to wait by default for instance 20-50ms between tearDownRequested and teardownDone

Fri, May 22, 1:12 PM · Dolphin

Mar 27 2020

alnikiforov added a comment to D28337: Fix unmounting during preview generation.

It's also may be possible to repeat unmount request from solid a few times with some delays between requests to try waiting until preview jobs are stopped when unmount is requested from 'mounted devices' widget. I've tried 5 retries with 2 seconds between each one, and it worked for me. But waiting for replies to unmount notifications in solid might be preferable to retries.

Mar 27 2020, 3:30 PM · Dolphin
alnikiforov requested review of D28337: Fix unmounting during preview generation.
Mar 27 2020, 12:24 PM · Dolphin

Mar 12 2020

alnikiforov added a comment to D28007: libarchive backend: display permissions in octal format.

Comparison of result before change and after change:

Mar 12 2020, 11:56 AM · Ark
alnikiforov requested review of D28007: libarchive backend: display permissions in octal format.
Mar 12 2020, 11:54 AM · Ark

Mar 10 2020

alnikiforov added a comment to D27703: Filelight: filter out duplicate paths.

lgtm.

Mar 10 2020, 7:54 AM

Mar 6 2020

alnikiforov added a comment to D27357: Fix infinite recursion in xscreensaver plugin.

Could you please merge this change? Or is something stopping from merging it?

Mar 6 2020, 12:01 PM · Frameworks

Mar 4 2020

alnikiforov added a comment to D27774: Contents tree: add fallback to URL without fragment.

There are other pending requests that were pending uncommitted. Would you like to push them into the repo first?

Mar 4 2020, 7:19 AM · Documentation

Mar 2 2020

alnikiforov requested review of D27774: Contents tree: add fallback to URL without fragment.
Mar 2 2020, 8:26 AM · Documentation

Feb 28 2020

alnikiforov updated the diff for D27703: Filelight: filter out duplicate paths.

Updated change to obtain information only about last device mounted over specific mount path. At least filesystem may be different in such case.

Feb 28 2020, 8:03 AM

Feb 27 2020

alnikiforov requested review of D27703: Filelight: filter out duplicate paths.
Feb 27 2020, 3:36 PM
alnikiforov added a comment to D27650: ItemContainer: disconnect signals in destructor.

Can I have your full name + email address please.

Feb 27 2020, 11:53 AM · Plasma

Feb 26 2020

alnikiforov updated the diff for D27650: ItemContainer: disconnect signals in destructor.

Got rid of two disconnects and updated summary formatting.

Feb 26 2020, 1:03 PM · Plasma
alnikiforov added inline comments to D27650: ItemContainer: disconnect signals in destructor.
Feb 26 2020, 11:27 AM · Plasma
alnikiforov added a comment to D27650: ItemContainer: disconnect signals in destructor.

And this used QWeakPointer leads to premature destruction of object m_layout points to.

Do you have commit access?

Feb 26 2020, 11:26 AM · Plasma
alnikiforov added a comment to D27650: ItemContainer: disconnect signals in destructor.

Fix consists of following line:

Feb 26 2020, 8:27 AM · Plasma
alnikiforov updated the diff for D27650: ItemContainer: disconnect signals in destructor.

Uploaded updated change

Feb 26 2020, 8:21 AM · Plasma
alnikiforov added a comment to D27650: ItemContainer: disconnect signals in destructor.

This function takes a plain pointer and wraps it into weak shared pointer.

That's QWeakPointer.

QPointer is something else that doesn't have an equivalent in stdlib.
It takes a QObject, then QObject has a special hook to unset watching QPointers to nullptr in QObject::~QObject()

Feb 26 2020, 8:19 AM · Plasma

Feb 25 2020

alnikiforov requested review of D27650: ItemContainer: disconnect signals in destructor.
Feb 25 2020, 2:21 PM · Plasma

Feb 18 2020

alnikiforov added a comment to D27404: Hide empty top-level menu items.

Could you please take a look at this change as well?

Feb 18 2020, 12:15 PM · Documentation

Feb 14 2020

alnikiforov added a comment to D27405: Hide group menu items if they have no children.

Here's screenshot of empty Science and Development groups being visible before this change is applied:

Feb 14 2020, 3:27 PM · Documentation
alnikiforov requested review of D27405: Hide group menu items if they have no children.
Feb 14 2020, 3:25 PM · Documentation
alnikiforov added a comment to D27404: Hide empty top-level menu items.

Here's how empty "Other Settings Modules" entry looks when selected:

Feb 14 2020, 3:18 PM · Documentation
alnikiforov requested review of D27404: Hide empty top-level menu items.
Feb 14 2020, 3:17 PM · Documentation
alnikiforov requested review of D27403: Hide top level scrollkeeper menu item if it's empty.
Feb 14 2020, 3:07 PM · Documentation

Feb 13 2020

alnikiforov added a comment to D27357: Fix infinite recursion in xscreensaver plugin.

Neither the XSync nor the windows backend explicitly call resumingFromIdle in simulateUserActivity, so I think this should be fine.
However, I don't know if that won't indirectly trigger it if the session was idle? Maybe we need to check if the session was idle and only then emit the signal.

Feb 13 2020, 1:32 PM · Frameworks
alnikiforov abandoned D27276: Powerdevil: allow using qt5widget classes with powerdevil.

Abandoning in favour of D27279 and D27357

Feb 13 2020, 1:12 PM · Plasma
alnikiforov requested review of D27357: Fix infinite recursion in xscreensaver plugin.
Feb 13 2020, 9:35 AM · Frameworks
alnikiforov added a comment to D27279: Port away from QWidget.

I think I found source of infinite recursion.

Feb 13 2020, 9:23 AM · Frameworks

Feb 12 2020

alnikiforov added a comment to D27279: Port away from QWidget.

I've managed to reproduce it and take a backtrace. It's an infinite recursion. Eventually stack's end is reached, although it takes some time to do it. Here's a piece of backtrace I got:

Feb 12 2020, 2:32 PM · Frameworks
alnikiforov added a comment to D27279: Port away from QWidget.

I've tested this patch in it's current form, and powerdevil no longer crashes for me on launch too. How can I reproduce crash in resume on idle? Can it be done in virtual machine?

Feb 12 2020, 11:53 AM · Frameworks

Feb 10 2020

alnikiforov added a comment to D27276: Powerdevil: allow using qt5widget classes with powerdevil.

Thanks, I'll try reworking KIdleTime.

Feb 10 2020, 11:25 AM · Plasma
alnikiforov updated the diff for D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present.

Updated remaining conditions

Feb 10 2020, 11:24 AM · Plasma
alnikiforov added a comment to D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present.

Makes sense, this can go into 5.18 branch.
Do I need to land this for you?

Feb 10 2020, 11:00 AM · Plasma
alnikiforov added a comment to D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present.

There seem to be a bunch of additional m_helper.isNull() that could be ported to be consistent?

Feb 10 2020, 10:59 AM · Plasma
alnikiforov updated the diff for D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present.

Fixed superfluous parenthesis in one of conditions.

Feb 10 2020, 10:54 AM · Plasma
alnikiforov added inline comments to D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present.
Feb 10 2020, 10:46 AM · Plasma
alnikiforov requested review of D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present.
Feb 10 2020, 10:29 AM · Plasma
alnikiforov added reviewers for D27276: Powerdevil: allow using qt5widget classes with powerdevil: apol, davidedmundson.
Feb 10 2020, 10:01 AM · Plasma
alnikiforov planned changes to D27276: Powerdevil: allow using qt5widget classes with powerdevil.

I've hit this crash trying to use KDE via x2go (https://wiki.x2go.org/doku.php) with both x2go client and server running in two separate VMs.

Feb 10 2020, 10:00 AM · Plasma
alnikiforov updated the summary of D27276: Powerdevil: allow using qt5widget classes with powerdevil.
Feb 10 2020, 9:47 AM · Plasma
alnikiforov requested review of D27276: Powerdevil: allow using qt5widget classes with powerdevil.
Feb 10 2020, 9:47 AM · Plasma

Oct 15 2019

alnikiforov added a comment to D24653: discover: check package status before trying to install/update it.
In D24653#547385, @apol wrote:

Please submit to master.

Oct 15 2019, 12:01 PM · Plasma
alnikiforov updated the diff for D24653: discover: check package status before trying to install/update it.
Oct 15 2019, 11:20 AM · Plasma
alnikiforov requested review of D24653: discover: check package status before trying to install/update it.
Oct 15 2019, 7:34 AM · Plasma