This is an Okular specific fix. However any application that uses KMainWindow could run into the same problem, so I wonder if there's a way to harden frameworks kxmlgui against that dangling pointer issue?

"wrap anywhere" seems really a bit strange. I'd expect something like "wrap at word boundaries", "don't wrap but write across margins" or "enlarge rectangle on demand" from any sane tool. Qt::TextWordWrap would be fine for me.

Do you think it would be useful to have adjustable text color for inline notes, too? Then I'll prepare a similar patch.

Also, since it's working for you, would you mind sending me a quick screenshot that shows both a colored typewriter annotation and also the colored toolbar icon? That's a really nice touch.

In D15205#336743, @ngraham wrote:

Ah yeah, Neon only has Poppler 0.62.

So the color changing feature just doesn't work without Poppler 0.69? If that's the case, we should probably turn it off unless you have a good enough Poppler version.

In D15205#336714, @ngraham wrote:

I know it's a little late, but now that this has landed, I tried it out so I could add a picture of it to this week's Usability & Productivity post, but I couldn't get it to work. What am I doing wrong?

In T8076#162844, @simgunz wrote:

I'll put all the items by themselves in the new annotation toolbar, there should be enough space.

Should be ready to land. I'll push tomorrow, time frame for last objections is open now ;-)

More review fixes

• Refine doxygen comments on TextAnnotation::textColor and TextAnnotation::setTextColor
• Colorize toolbar icon in with text color instead of black
• Remove accidential whitespace change

In D15205#335752, @sander wrote:

I now actually tested and it works very nicely. I'll approve the diff, because I don't have a strong opinion on the whitespace issue.

Really rebase on master

Rebase on master. Some review fixes.

@sander Thanks for the review!

This revision should be quite complete now.

Review fixes

In T8076#160398, @simgunz wrote:

@tobiasdeiminger ..and yes I would like to coordinate so we don't waste effort.

It took some minutes until I realized how to change from ellipse to polygon (long left press). Now I find it good and easy. Would there be a way to make it even more self explaining?

How would the new color picker handle "multi-color" annotations? I ask, because D15205 brings selectable font color for typewriter tool. Inline note is very similar, so I had intended to submit a font color patch for inline note too. This would bring annotations with two different color values, namely background color and font color. Given the related poppler patch for FreeText has already landed, and typewriter is ready for review, that's not too hypothetical. We could even go one step further, and introduce a third color for the border.

Nice approach👍 D15204, D15205 and D15580 conflict somewhat. Not bad, but whoever gets in later will have to adapt. Shall we try to coordinate?

Fix check for m_sleepInhibitFd

In D15347#322414, @aacid wrote:

Do you think it'd make sense to actually fix the bug you mentioned instead of changing click to a queued invoke? Feels a bit weird to be honest

No real changes, just follow rebase of parent revision D15204.

D15279 has landed, we can depend on master again.
Factor out autotests. Will be moved on top of revision stack.

I'm going to push, and want to do it on behalf of @dileepsankhla who did the original work. I.e. my Phab revision, but git commit author should be him.
Has anybody tried with arc land? Will this work?

$ git commit --amend --author="Original Author <email@address.com>"
$ arc land

So what now? The patch seems to do something reasonable, but it does not do what you claim it does.

In D15279#320991, @sander wrote:

I cannot reproduce Part 1 of your test plan. When I delete my okularpartrc and start Okular (with the patch), then the freshly created okularpartrc file

When is your new okularpartrc created exactly? Afaikt, it should not be created right on startup, but only when you modify some tool in the config dialog.

Remove reintroduced whitespace change.

Rebase on D15204. Check for poppler 0.69.

Rebased on D15279, to factor out ARGB format change. Fix whitespace change.

In D15204#320195, @sander wrote:

Would it a good idea to split those changes that deal with the color alpha channel into a separate patch? That would make reviewing easier, and lead to more legible git history.

In D13203#314558, @sander wrote:

I'd like to split this into two new Diffs

Sounds like a good idea to me.

Here's a PDF and LaTex source, suitable to trigger and test OkularLinkType::setAnnotation in resolveMediaLinks.

I'd like to split this into two new Diffs

1. Add typewriter (everything until ID 36397)
2. Add fontcolor support (the reminder, depends on "Add typwriter")

It's easier to review and test. And, the first part could land quite immediately, the second part depends on a pending poppler patch that needs some more research.

I'm currently looking for documents to test the resolveMediaLinkReferences stuff. It requires documents containing pages, screen/widget annotations, or form fields - with associated open or close additional action, of action type movie or rendition. Does anybody have such files laying around?

@sander Here's a bit of explanation how I understand it. Maybe you can extract comments / commit message / documentation from it.

Alberts patch works for me and I don't know another solution that would be reasonable simple. BUG: 397373 is a side effect of deferred ("lazy") link setup inside PDFGenerator. Deferred link setup is an implementation detail of PDFGenerator, and so its side effects have to be mitigated also locally to PDFGenerator. PDFGenerator::swapBackingFile is the most obvious place.

Typewriter annotations created with the initial typewriter tool have a border of width=1 (Okular started without existing okularpartrc). But we always want border width = 0 for typewriter, is it? It could even be hardcoded into drawing code.

In D13203#271231, @dileepsankhla wrote:

I mean isn't it enough to change the line to acolor.setAlpha( a->style().opacity() * a->style().color().alpha() ) as you suggested? Why do we need to change the Poppler's one?

In D13203#270937, @tobiasdeiminger wrote:

In D13203#270910, @dileepsankhla wrote:

In ui/pagepainter.cpp L 668, we can comment out acolor.setAlpha( opacity ) as here the value of opacity is 255 but changing the L 659 or 668 should be consistent in the case of other annotations too. Is commenting out L 668 accepted?

if ( inplaceIntent == Okular::TextAnnotation::InplaceIntent ) acolor.setAlpha(0);

in PagePainter.

Any other ideas?

In D13203#270910, @dileepsankhla wrote:

In ui/pagepainter.cpp L 668, we can comment out acolor.setAlpha( opacity ) as here the value of opacity is 255 but changing the L 659 or 668 should be consistent in the case of other annotations too. Is commenting out L 668 accepted?

In D13203#270421, @ngraham wrote:

Hmm, what can this do that the regular text annotation tool can't?

The typewriter feature should ultimately get an UI similar to the Adobe Reader typewriter tool, but we decided to start with a less breaking and more working patch 😄 Therefore Dileep just reuses the inline note tool. The resulting annotation differs from inline note in making background always transparent and setting PDF field "intent" to FreeTextTypeWriter to ensure interoperability with other PDF tools. This fulfills the minimal requirements for a typewriter tool.

If I use the new tool to typewrite onto a plain text file, I get opaque white background instead of transparent background. Transparency does work for PDF documents (i.e. rendered by poppler). In the former case the typewriter annotation is drawn in ui/pagepainter.cpp L.680. Can you checkout what's wrong there?

In D13203#270423, @dileepsankhla wrote:

I have committed the same to my separate branch: https://cgit.kde.org/okular.git/log/?h=gsoc2018_typewriter but don't know how it got landed! It needs to be reviewed first. Have I done something wrong?

One thing that may fix it is changing

m_sidebar = new Sidebar( parentWidget );

to

m_sidebar = new Sidebar();

in part.cpp, this micht change the part/child relationships and get yourself of this problem. can you give it a quick try?

One can only change Name, Visible To, Subscribers in Edit File. But no file content. And I guess that's ok, I should not try to abuse the file app as a code review tool for external projects code.

The comments in the patch should be as follows. How can I edit the attached file?

// 1 x units in AP_* will be scaled with sx = (rect->x2 - rect->x1) / 24
// 1 y units in AP_* will be scaled with sy = (rect->y2 - rect->y1) / 24

This is a demonstration how BUG 387639, BUG 388458 and D9615 can be solved by poppler. If applied, poppler draws text annotation icons according to what was set in Poppler::Annotation::setBoundary, or what's defined in /Rect (in the case of an external PDF writer). It works because the transformation matrix in Gfx::drawAnnot gets prepared so that 24 x units from the appearance stream will become width = x2 - x1 units from the /Rect. The patch should apply to current poppler master.

Remove unnecessary brackets.