Draw non-external text annotations with word wrap
ClosedPublic

Authored by aacid on Oct 11 2018, 11:01 PM.

Details

Summary

Instead of with wrap anywhere

BUGS: 398604

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3781
Build 3799: arc lint + arc unit
aacid created this revision.Oct 11 2018, 11:01 PM
Restricted Application added a project: Okular. · View Herald TranscriptOct 11 2018, 11:01 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
aacid requested review of this revision.Oct 11 2018, 11:01 PM

I'm unconvinced whether this is actually better, but it's somehow similar to what poppler does, so maybe it makes sense?

"wrap anywhere" seems really a bit strange. I'd expect something like "wrap at word boundaries", "don't wrap but write across margins" or "enlarge rectangle on demand" from any sane tool. Qt::TextWordWrap would be fine for me.

Just tried it, Calligra Words uses word wrap for text frames by default, too.

cfeck accepted this revision.Nov 8 2018, 10:13 PM
This revision is now accepted and ready to land.Nov 8 2018, 10:13 PM
aacid closed this revision.Nov 8 2018, 11:25 PM