Differential D15344

Fix isNull check for RegularArea
ClosedPublic
Actions

Authored by tobiasdeiminger on Sep 8 2018, 8:50 AM.

Details

Reviewers
aacid
Commits
R223:0128f33f43eb: Fix isNull check for RegularArea
Summary

First check in RegularArea::isNull sais this: "I'm a QList. If I'm empty, I'm not null". That doesn't make sense, invert it.

The next check says: "If I contain at least one shape which is not null, I'm not null.". That makes sense, keep it.

Test Plan
  • check for regression in callers (TextPage::findText, TextPage::text, TextPage::words)

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tobiasdeiminger created this revision.Sep 8 2018, 8:50 AM
Restricted Application added a project: Okular. · View Herald TranscriptSep 8 2018, 8:50 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
tobiasdeiminger requested review of this revision.Sep 8 2018, 8:50 AM
aacid accepted this revision.Sep 8 2018, 5:50 PM
This revision is now accepted and ready to land.Sep 8 2018, 5:50 PM
Closed by commit R223:0128f33f43eb: Fix isNull check for RegularArea (authored by tobiasdeiminger). · Explain WhySep 8 2018, 8:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcore/area.h (2 lines)

Diff 41222

View Options

core/area.h

Loading...