Yep. tested locally and fixes the problem

agree that fullName() -> aBetterName() change should go into a separate patch.
+1

also see this crash in impptest

I've also been seeing those test failures for a long time.
seems to break if you aren't in the CET timezone (or somesuch). Harmless, but annoying.

deprecate fullName() and replace with fullEmail()?

remove unnecssary clang-analyzer-optin.cplusplus.VirtualCall fixes and add NOLINT comments so clang-tidy ignores them

In D21036#461578, @dvratil wrote:

Well, technically, calling virtual methods from ctor in dtor in those particular cases is safe and your changes do not have any impact, since the standard says that when a ctor/dtor calls a virtual function of the object currently under construction/destruction the override called is that of the current ctor's/dtor's class - in other words, it will never call an override in a more-derived class (and calling an override in a superclass is safe, because that one is already constructed/not yet destroyed). This would only be a problem (or undefined behavior, rather) if any of those methods were pure virtual, which they are not so this might be considered a false-positive from clazy.

Edit: there's also some trickyness in this when non-linear inheritance in involved, but that's not the case here either.

ping

Pino's suggestion
added tests

I'll assume you rebuilt all of kde pim ok

missing changes for QLatin1String()
thanks for noticing Achim

Dan's comments and suggestions

I will fix those 'auto' variables. I had planned a clang-tidy round of cleanups, but I can do the auto stuff here.
your other suggestions are also good. I'll handle them.

yes please

remove commented out lines I added during testing

goodie

I'm for this.
I never created such a patch because I wasn't sure what minimum version was needed.

I applied this patch locally for testing. so far so good.

this would be a nice addition to Krazy. on my todo list.

do you have commit access? If not I can commit for you

do you have commit access? If not I can commit for you

this patch breaks my geometry changes upon restart of korgac.

Volker has a good point. Incidences can have geo coordinates so an even better idea is to provide location based on that.

I'll commit this for you.
it seems to work, at least as much as I can tell.

sorry, I completely missed this.
I'll take a look

fyi, krazy in strict mode will check for leading and trailing underscores on the include guards.
I don't run krazy in strict mode on the EBN, however.

rebased

ship it!

one last question. we are adding a static public method. should we increase the version number?

Yay Dan!
add the @since and we're good to go