Replace sprintf with QString::asprintf
ClosedPublic

Authored by nicolasfella on May 12 2019, 4:56 PM.

Details

Summary

sprintf is obsolete and causes build fail with current Qt dev. Use asprintf

Test Plan

ctest

Some tests fail, but they did before:
472 - Compat-libical3-AppleICal_1.5.ics (Failed)
473 - Compat-libical3-Evolution_2.8.2_timezone_test.ics (Failed)
475 - Compat-libical3-KOrganizer_3.1a.ics (Failed)
477 - Compat-libical3-MSExchange.ics (Failed)
478 - Compat-libical3-Mozilla_1.0.ics (Failed)

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.May 12 2019, 4:56 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 12 2019, 4:56 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
nicolasfella requested review of this revision.May 12 2019, 4:56 PM
nicolasfella edited the summary of this revision. (Show Details)May 12 2019, 4:57 PM
nicolasfella edited the test plan for this revision. (Show Details)
nicolasfella added a reviewer: KDE PIM.
vkrause accepted this revision.May 12 2019, 5:55 PM
This revision is now accepted and ready to land.May 12 2019, 5:55 PM

I've also been seeing those test failures for a long time.
seems to break if you aren't in the CET timezone (or somesuch). Harmless, but annoying.

I spent too much time looking how to fix and never found a solution that doesn't break the test for people in other timezones.

This revision was automatically updated to reflect the committed changes.