KContacts - clang-tidy fixes
ClosedPublic
Actions

Authored by winterz on May 6 2019, 5:37 PM.

Details

Reviewers

Commits

R174:60ff2f4633c6: various - clang-tidy fixes

Summary

Fix some issues reported by clang-tidy.

Notice that I removed include <stdlib.h> as I don't think it's needed any longer; let the CI verify that.
(else use <cstdlib>

Test Plan

make && make test still work

Repository

R174 KContacts

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

winterz requested review of this revision.May 6 2019, 5:37 PM

This revision is now accepted and ready to land.May 6 2019, 7:42 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/importexportvcardtest.cpp (4 lines)
M			autotests/phonenumbertest.cpp (6 lines)
M			autotests/testroundtrip.cpp (4 lines)
M			src/converter/ldifconverter.cpp (2 lines)
M			src/generator/main.cpp (3 lines)
M			src/picture.cpp (4 lines)
M			tests/testread.cpp (1 line)