Don't inherit Attendee from Person
ClosedPublic

Authored by vkrause on May 9 2019, 4:54 PM.

Details

Summary

This fixes the slicing issue for (de)serialization brought up during the
KF5 review. Maybe even more important, this enables us to transform both
classes into simple value types. That would not only be more efficient by
avoiding some extra allocations, it would also enable direct consumption
of those types from QML.

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.May 9 2019, 4:54 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 9 2019, 4:54 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.May 9 2019, 4:54 PM
winterz added a subscriber: winterz.May 9 2019, 8:25 PM

deprecate fullName() and replace with fullEmail()?

src/person_p.h
30

fullEmailAddressHelper() instead of fullNameHelper)( ?

deprecate fullName() and replace with fullEmail()?

Right, I'm not particular happy with the "fullName()" name either. IMHO that's a separate change though, this change did not introduce that name.

winterz accepted this revision.May 13 2019, 4:16 PM

agree that fullName() -> aBetterName() change should go into a separate patch.
+1

This revision is now accepted and ready to land.May 13 2019, 4:16 PM
This revision was automatically updated to reflect the committed changes.