Differential D21223

Put the IM protocol files into a QResource
ClosedPublic
Actions

Authored by vkrause on May 15 2019, 7:07 AM.

Details

Reviewers
mlaurent
winterz
Commits
R174:db650d7236b6: Put the IM protocol files into a QResource
Summary

This should address the unit test issues that Allen and Nico reported,
and that the Windows CI also shows. It also makes the test work without
prior installation.

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.May 15 2019, 7:07 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 15 2019, 7:07 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.May 15 2019, 7:07 AM
mlaurent accepted this revision.May 15 2019, 7:12 AM
This revision is now accepted and ready to land.May 15 2019, 7:12 AM
winterz accepted this revision.May 15 2019, 1:28 PM
winterz added a subscriber: winterz.

Yep. tested locally and fixes the problem

Closed by commit R174:db650d7236b6: Put the IM protocol files into a QResource (authored by vkrause). · Explain WhyMay 15 2019, 1:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (2 lines)
Msrc/impp.cpp (16 lines)
DMsrc/improtocols/CMakeLists.txt (19 lines)
AMsrc/improtocols/improtocols.qrc (20 lines)

Diff 58124

View Options

src/CMakeLists.txt

Loading...
View Options

src/impp.cpp

Loading...
View Options

src/improtocols/CMakeLists.txt

Loading...
View Options

src/improtocols/improtocols.qrc

Loading...