| vkrause | |
| mlaurent | |
| dvratil |
more clang-tidy fixes:
clang-analyzer-deaddode.DeadStores in recurrencerule.cpp clang-analyzer-optin.cplusplus.VirtualCall in calendar.cpp, freebusy.cpp, incidence.cpp, memorycalendar.cpp readability-redundant-control-flow in freebusy.cpp readability-avoid-const-params-in-decls in memorycalendar.cpp
make && make test still work
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Well, technically, calling virtual methods from ctor in dtor in those particular cases is safe and your changes do not have any impact, since the standard says that when a ctor/dtor calls a virtual function of the object currently under construction/destruction the override called is that of the current ctor's/dtor's class - in other words, it will never call an override in a more-derived class (and calling an override in a superclass is safe, because that one is already constructed/not yet destroyed). This would only be a problem (or undefined behavior, rather) if any of those methods were pure virtual, which they are not so this might be considered a false-positive from clazy.
Edit: there's also some trickyness in this when non-linear inheritance in involved, but that's not the case here either.
remove unnecssary clang-analyzer-optin.cplusplus.VirtualCall fixes and add NOLINT comments so clang-tidy ignores them