Thanks again, I have already pushed you original suggestions, see https://github.com/KDE/ktouch/commit/799d2d1a1619caef5787b91a5cbb92a1dd8d6b7a

In D23048#510825, @manuelal wrote:

This (and the changes here) should go into the Applications/19.08 branch

I'm new to contribute to KDE. Is this done automatically or I need to do something else?

With Phabricator, an automatic merge is not possible, unfortunately. It can only do code review.

Thanks for the update!

Sorry for the long wait. I discovered a crash in the keyboard layout editor which I suspected to be related to you work, but it is not. Still, I wanted to figure this out first.

I found two more spots which leak connections over time. These should be fixed.

Looks mostly good and works as intended. But its seems you have missed the member declarations and include directives:

Good to go.

Thanks for the patch. If you change the dependencies in the CMake files, you also need to update the README so they stay in sync.

In D22313#493883, @asturmlechner wrote:

Okay then... I do have commit access, fyi.

I took your patch and fixed the remaining issues. I think, this review can be closed now.

In D22313#492604, @aacid wrote:

@gottfried any reason you removed kde edu from the list of subscribers?

If no one objects within a week, I am going the merge this.

In D20953#477062, @aacid wrote:

There's a few relative scary warnings though

qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:367:25: QML LearningProgressChart: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:286:21: QML Label: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:293:21: QML ComboBox: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:306:21: QML Label: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:316:21: QML ComboBox: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:337:21: QML LegendItem: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:345:21: QML LegendItem: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:162:17: QML IconToolButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/homescreen/ProfileSelector.qml:90: TypeError: Cannot read property 'isNewButton' of null

have you seen this?

I don't see the layout warnings. Maybe you Qt is more recent than mine. Nonetheless, they should all be fixed now.

Fix QML runtime warnings.

In D20953#460428, @ognarb wrote:

In D20953#459771, @gottfried wrote:

In D20953#459468, @ognarb wrote:

Hi, not a KTouch dev, but I found a typo. ;)

Yay, I'm basically the only one developing features for KTouch. I still value review for non-trivial changes, though.

:) So I tried it on my machine on it worked very well. :) Can't really comment about the code but found the sidebar shadow a bit strange. The shadow gave me the wrong impression that the sidebar is collapsible. Maybe you could ask the VDG for feedback. Otherwise, the UI looks great.

Thank you. I can see your point. I have added the shadow as visual separator between the sidebar and the lesson grid. I agree its a bit misleading. Maybe the VDG has a better idea.

In D20953#459468, @ognarb wrote:

Hi, not a KTouch dev, but I found a typo. ;)

Yay, I'm basically the only one developing features for KTouch. I still value review for non-trivial changes, though.

Fix Typo in checkqmlimports.py

Works as advertised.

I have pushed the changes to the KTouch Git repository.

Hi Simone,

I have added your course to KTouch, see https://cgit.kde.org/ktouch.git/commit/?id=8598e4af105418a92d54f5dbfbbaf04be9a492d7. It will be part of the upcoming 18.04 release.

Alright, I will wait.

Hi Simone,