qSort and QSignalMapper are deprecated and spoil the compilation messages with warnings:
https://build.kde.org/job/Applications/job/ktouch/job/kf5-qt5%20FreeBSDQt5.13/10/warnings12Result/
This patch tries to get rid of these warnings.
Details
Details
- Reviewers
gottfried - Group Reviewers
KDE Edu - Commits
- R336:77fde8f2329e: Replace obsolete QSignalMapper and qSort with non-obsolete code
- Compile (there should be no warnings with Qt 5.13).
- Run KTouch, open the course and layout editor and create a course. The new item should be correctly added to the lists in the Editor and the main KTouch window. Delete the course.
- Add a layout. Add a key. Resize the key. KTouch should behave as expected. Remove the layout.
Diff Detail
Diff Detail
- Repository
- R336 KTouch
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks mostly good and works as intended. But its seems you have missed the member declarations and include directives:
ktouch/src$ grep -r "QSignalMapper" models/lessonmodel.cpp:#include <QSignalMapper> models/charactersmodel.h:class QSignalMapper; models/charactersmodel.h: QSignalMapper* m_signalMapper; models/resourcemodel.h:class QSignalMapper; models/resourcemodel.h: QSignalMapper* m_signalMapper; models/resourcemodel.cpp:#include <QSignalMapper> models/charactersmodel.cpp:#include <QSignalMapper> models/lessonmodel.h:class QSignalMapper; models/lessonmodel.h: QSignalMapper* m_signalMapper; core/course.cpp:#include <QSignalMapper> core/keyboardlayout.h:class QSignalMapper; core/keyboardlayout.h: QSignalMapper* m_signalMapper; core/course.h:class QSignalMapper; core/course.h: QSignalMapper* m_signalMapper; core/keyboardlayout.cpp:#include <QSignalMapper>
Can you please remove these?
| src/models/lessonmodel.cpp | ||
|---|---|---|
| 150–155 | updateMappings is called multiple times. If I am not mistaken, this will result in multiple connections to the lambda with different values of ì of you don't disconnect() first. | |
Comment Actions
Sorry for the long wait. I discovered a crash in the keyboard layout editor which I suspected to be related to you work, but it is not. Still, I wanted to figure this out first.