gottfried (Sebastian Gottfried)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 4:07 PM (221 w, 4 d)
Availability
Available

Recent Activity

Tue, Jul 16

gottfried committed R336:66242fe784ca: Merge Branch 'Applications/19.08' (authored by gottfried).
Merge Branch 'Applications/19.08'
Tue, Jul 16, 7:10 PM
gottfried committed R336:bea9d4df88ca: Add a Simple Build Script (authored by gottfried).
Add a Simple Build Script
Tue, Jul 16, 7:06 PM
gottfried committed R336:a3a7bf9d466c: Build w/o X11: Better Course Selection UI (authored by gottfried).
Build w/o X11: Better Course Selection UI
Tue, Jul 16, 7:06 PM

Sun, Jul 14

gottfried accepted D22389: Make Qt5X11Extras optional.

Good to go.

Sun, Jul 14, 8:22 AM · KDE Edu

Sat, Jul 13

gottfried committed R336:5427e1870ff4: Build w/o X11: Remove Keyboard Layout Menu (authored by gottfried).
Build w/o X11: Remove Keyboard Layout Menu
Sat, Jul 13, 11:47 AM

Thu, Jul 11

gottfried added inline comments to D22389: Make Qt5X11Extras optional.
Thu, Jul 11, 7:02 AM · KDE Edu
gottfried requested changes to D22389: Make Qt5X11Extras optional.

Thanks for the patch. If you change the dependencies in the CMake files, you also need to update the README so they stay in sync.

Thu, Jul 11, 6:28 AM · KDE Edu

Wed, Jul 10

gottfried added a comment to D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.

Okay then... I do have commit access, fyi.

Wed, Jul 10, 8:40 PM · KDE Edu
gottfried added a comment to D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.

I took your patch and fixed the remaining issues. I think, this review can be closed now.

Wed, Jul 10, 7:51 PM · KDE Edu
gottfried committed R336:56ec6f23e9c4: Set a CMake Policy Version (authored by gottfried).
Set a CMake Policy Version
Wed, Jul 10, 7:47 PM
gottfried committed R336:4cba35d316e0: Fix Build Without X11 Deps (authored by gottfried).
Fix Build Without X11 Deps
Wed, Jul 10, 7:47 PM
gottfried committed R336:9726ef8fc020: README: Fix Instructions to Install Dependencies (authored by gottfried).
README: Fix Instructions to Install Dependencies
Wed, Jul 10, 7:47 PM
gottfried committed R336:83186d9f8c04: Home Screen: Improve Wording (authored by gottfried).
Home Screen: Improve Wording
Wed, Jul 10, 7:47 PM

Tue, Jul 9

gottfried added a comment to D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.

@gottfried any reason you removed kde edu from the list of subscribers?

Tue, Jul 9, 6:17 AM · KDE Edu

Mon, Jul 8

gottfried committed R336:45abc5feef1e: Score Screen: Fix Display of Error Chart (authored by gottfried).
Score Screen: Fix Display of Error Chart
Mon, Jul 8, 7:02 PM
gottfried edited reviewers for D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition, added: gottfried; removed: KDE Edu.
Mon, Jul 8, 7:38 AM · KDE Edu

Thu, Jul 4

gottfried committed R336:106d3bbe7725: Merge Branch 'homescreen-ng' (authored by gottfried).
Merge Branch 'homescreen-ng'
Thu, Jul 4, 9:06 PM
gottfried closed D20953: New Home Screen for KTouch.
Thu, Jul 4, 9:06 PM · KDE Edu
gottfried committed R336:ae2b5d6396c2: Merge Branch 'Applications/19.04' (authored by gottfried).
Merge Branch 'Applications/19.04'
Thu, Jul 4, 6:54 AM
gottfried committed R336:032067dc63c3: Fix Chart Legend Visibility with Dark Color Scheme (authored by gottfried).
Fix Chart Legend Visibility with Dark Color Scheme
Thu, Jul 4, 6:52 AM

Thu, Jun 27

gottfried added a comment to D20953: New Home Screen for KTouch.

If no one objects within a week, I am going the merge this.

Thu, Jun 27, 3:24 PM · KDE Edu
gottfried committed R336:7eede2ae198c: Merge Branch 'Applications/19.04' (authored by gottfried).
Merge Branch 'Applications/19.04'
Thu, Jun 27, 3:06 PM
gottfried committed R336:2114304bfaf3: Fix Dimensions of Key Hints During Training (authored by gottfried).
Fix Dimensions of Key Hints During Training
Thu, Jun 27, 3:05 PM
gottfried committed R336:9063b5de23e9: Fix Key Item Scaling Issues (authored by gottfried).
Fix Key Item Scaling Issues
Thu, Jun 27, 3:05 PM

Fri, Jun 21

gottfried committed R336:6e9e5feb7989: Merge Branch 'Applications/19.04' (authored by gottfried).
Merge Branch 'Applications/19.04'
Fri, Jun 21, 11:38 AM
gottfried committed R336:1c55e2016ded: Fix Layout of Infomation Tables (authored by gottfried).
Fix Layout of Infomation Tables
Fri, Jun 21, 11:36 AM

Thu, Jun 20

gottfried committed R336:d8a8882dae75: Fix Crash when Closing Resource Editor (authored by gottfried).
Fix Crash when Closing Resource Editor
Thu, Jun 20, 7:35 AM

Wed, Jun 19

gottfried committed R336:0ad223458ca9: Fix Crash when Closing Resource Editor (authored by gottfried).
Fix Crash when Closing Resource Editor
Wed, Jun 19, 2:50 PM

Jun 17 2019

gottfried added a comment to D20953: New Home Screen for KTouch.

There's a few relative scary warnings though

qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:367:25: QML LearningProgressChart: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:286:21: QML Label: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:293:21: QML ComboBox: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:306:21: QML Label: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:316:21: QML ComboBox: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:337:21: QML LegendItem: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:345:21: QML LegendItem: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:162:17: QML IconToolButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/homescreen/ProfileSelector.qml:90: TypeError: Cannot read property 'isNewButton' of null

have you seen this?

I don't see the layout warnings. Maybe you Qt is more recent than mine. Nonetheless, they should all be fixed now.

Jun 17 2019, 9:22 PM · KDE Edu
gottfried updated the diff for D20953: New Home Screen for KTouch.

Fix QML runtime warnings.

Jun 17 2019, 9:22 PM · KDE Edu
gottfried committed R336:8b46599242b5: Scorescreen: Fix Warnings wrt Anchors with Layouts (authored by gottfried).
Scorescreen: Fix Warnings wrt Anchors with Layouts
Jun 17 2019, 9:18 PM
gottfried committed R336:7e5a468c691b: Profile Selector: Fix Runtime Error (authored by gottfried).
Profile Selector: Fix Runtime Error
Jun 17 2019, 9:18 PM

May 4 2019

gottfried committed R336:a44f36def494: Load QML Resources from 'ktouch' Prefix (authored by gottfried).
Load QML Resources from 'ktouch' Prefix
May 4 2019, 1:31 PM
gottfried committed R336:5302229ab635: Provide @2x Images for HiDPI Rendering (authored by gottfried).
Provide @2x Images for HiDPI Rendering
May 4 2019, 1:31 PM
gottfried committed R336:caa71318f3a2: Remove Home Baked Image Lookup (authored by gottfried).
Remove Home Baked Image Lookup
May 4 2019, 1:31 PM
gottfried added a comment to D20953: New Home Screen for KTouch.

Hi, not a KTouch dev, but I found a typo. ;)

Yay, I'm basically the only one developing features for KTouch. I still value review for non-trivial changes, though.

:) So I tried it on my machine on it worked very well. :) Can't really comment about the code but found the sidebar shadow a bit strange. The shadow gave me the wrong impression that the sidebar is collapsible. Maybe you could ask the VDG for feedback. Otherwise, the UI looks great.

Thank you. I can see your point. I have added the shadow as visual separator between the sidebar and the lesson grid. I agree its a bit misleading. Maybe the VDG has a better idea.

May 4 2019, 1:13 PM · KDE Edu

May 2 2019

gottfried added a comment to D20953: New Home Screen for KTouch.

Hi, not a KTouch dev, but I found a typo. ;)

Yay, I'm basically the only one developing features for KTouch. I still value review for non-trivial changes, though.

May 2 2019, 8:32 PM · KDE Edu
gottfried updated the diff for D20953: New Home Screen for KTouch.

Fix Typo in checkqmlimports.py

May 2 2019, 8:29 PM · KDE Edu
gottfried committed R336:a6d3d61c88c3: checkqmlimports.py: Fix Typo (authored by gottfried).
checkqmlimports.py: Fix Typo
May 2 2019, 8:26 PM
gottfried requested review of D20953: New Home Screen for KTouch.
May 2 2019, 9:27 AM · KDE Edu

Apr 28 2019

gottfried committed R336:35058b4198b9: Merge Branch 'master' Into 'homescreen-ng' (authored by gottfried).
Merge Branch 'master' Into 'homescreen-ng'
Apr 28 2019, 3:45 PM
gottfried accepted D20861: Make QML compilation optional.

Works as advertised.

Apr 28 2019, 3:34 PM · KDE Edu

Apr 11 2019

gottfried committed R336:c85605d8aa63: Eliminate Call to Deprecated Method (authored by gottfried).
Eliminate Call to Deprecated Method
Apr 11 2019, 5:47 PM
gottfried committed R336:ee5ec3346ecc: Fix All Compiler Warnings (authored by gottfried).
Fix All Compiler Warnings
Apr 11 2019, 5:47 PM
gottfried committed R336:f601057305fb: Fix Layout of Infomation Tables (authored by gottfried).
Fix Layout of Infomation Tables
Apr 11 2019, 5:47 PM
gottfried committed R336:76a6584faab8: Fix Title Case Issue (authored by gottfried).
Fix Title Case Issue
Apr 11 2019, 5:47 PM
gottfried committed R336:7ac2b7dd3f53: Fix TextArea Background (authored by gottfried).
Fix TextArea Background
Apr 11 2019, 5:47 PM

Mar 9 2019

gottfried committed R336:435a041a0364: Fix Crash in Lesson Selector (authored by gottfried).
Fix Crash in Lesson Selector
Mar 9 2019, 6:00 PM
gottfried committed R336:f6dbef90518c: Merge Branch 'master' into 'homescreen-ng' (authored by gottfried).
Merge Branch 'master' into 'homescreen-ng'
Mar 9 2019, 6:00 PM
gottfried committed R336:fc01b9b147cf: Fix Build Because of Missing Include (authored by gottfried).
Fix Build Because of Missing Include
Mar 9 2019, 6:00 PM

Feb 24 2019

gottfried committed R336:d9b49c523576: Update Basque Course (authored by gottfried).
Update Basque Course
Feb 24 2019, 3:48 PM
gottfried committed R336:3d978a90b06e: Update it2 Course (authored by gottfried).
Update it2 Course
Feb 24 2019, 3:48 PM
gottfried closed D18902: Fix it2 course.

I have pushed the changes to the KTouch Git repository.

Feb 24 2019, 3:41 PM · KDE Edu
gottfried accepted D18902: Fix it2 course.
Feb 24 2019, 3:39 PM · KDE Edu

Feb 16 2019

gottfried requested changes to D18902: Fix it2 course.

Hi Simone,

Feb 16 2019, 3:07 PM · KDE Edu

Jan 2 2019

gottfried committed R336:8598e4af1054: Add New Italian Course (authored by gottfried).
Add New Italian Course
Jan 2 2019, 7:34 PM
gottfried added a comment to D17914: Add improved lesson for Italian.

I have added your course to KTouch, see https://cgit.kde.org/ktouch.git/commit/?id=8598e4af105418a92d54f5dbfbbaf04be9a492d7. It will be part of the upcoming 18.04 release.

Jan 2 2019, 6:52 PM · KDE Edu
gottfried abandoned D17926: Add course as additional course..
Jan 2 2019, 6:45 PM · KDE Edu
gottfried added a dependent revision for D17914: Add improved lesson for Italian: D17926: Add course as additional course..
Jan 2 2019, 6:44 PM · KDE Edu
gottfried added a dependency for D17926: Add course as additional course.: D17914: Add improved lesson for Italian.
Jan 2 2019, 6:44 PM · KDE Edu
gottfried requested review of D17926: Add course as additional course..
Jan 2 2019, 6:43 PM · KDE Edu
gottfried added a comment to D17914: Add improved lesson for Italian.

Alright, I will wait.

Jan 2 2019, 3:51 PM · KDE Edu
gottfried requested changes to D17914: Add improved lesson for Italian.

Hi Simone,

Jan 2 2019, 1:30 PM · KDE Edu

Sep 4 2018

gottfried committed R336:07a95f1dfc97: Add New Italian Course and Update Keyboard Layout (authored by gottfried).
Add New Italian Course and Update Keyboard Layout
Sep 4 2018, 7:38 PM

May 17 2018

gottfried committed R336:7003d4208108: Extend README (authored by gottfried).
Extend README
May 17 2018, 8:45 PM
gottfried committed R336:989fb6dc5e19: Remove Commented Code (authored by gottfried).
Remove Commented Code
May 17 2018, 8:45 PM

May 3 2018

gottfried committed R336:919f8403f706: Learning Progess Charts: Show Training Dates (authored by gottfried).
Learning Progess Charts: Show Training Dates
May 3 2018, 4:26 PM
gottfried committed R336:e5fa58b5776f: Add Focus Indicator for Grid View (authored by gottfried).
Add Focus Indicator for Grid View
May 3 2018, 4:26 PM
gottfried committed R336:450d75d35149: Profile Selector: Tweak Layout (authored by gottfried).
Profile Selector: Tweak Layout
May 3 2018, 3:29 PM
gottfried committed R336:8a8729399b98: Fix Label in Profile Form (authored by gottfried).
Fix Label in Profile Form
May 3 2018, 3:29 PM
gottfried committed R336:d5049fc4a0d1: Learning Progess Charts: Embed Tooltips (authored by gottfried).
Learning Progess Charts: Embed Tooltips
May 3 2018, 3:29 PM
gottfried committed R336:78d9ba87455a: Key Item: Fix Shadow Appearance (authored by gottfried).
Key Item: Fix Shadow Appearance
May 3 2018, 3:29 PM
gottfried committed R336:0b4652e05393: Score Screen: Tweak Margins of Toolbar (authored by gottfried).
Score Screen: Tweak Margins of Toolbar
May 3 2018, 3:29 PM

Apr 18 2018

gottfried committed R954:a93f0bdebcb8: Update My Feed URL (authored by gottfried).
Update My Feed URL
Apr 18 2018, 1:17 PM

Mar 19 2018

gottfried accepted D11473: course de1. corrections 'Übung 2'.
Mar 19 2018, 8:03 AM · KDE Edu

Mar 17 2018

gottfried accepted D11401: Corrections course de1.

Thanks for the patch 😀

Mar 17 2018, 9:46 AM · KDE Edu
gottfried requested changes to D11401: Corrections course de1.
Mar 17 2018, 8:01 AM · KDE Edu

Jan 15 2018

gottfried committed R336:bdd4819be728: Score Screen: Use Normal ComboBox Items (authored by gottfried).
Score Screen: Use Normal ComboBox Items
Jan 15 2018, 8:49 PM
gottfried committed R336:17cccad00023: Score Screen: Port To QCC 2 (authored by gottfried).
Score Screen: Port To QCC 2
Jan 15 2018, 8:49 PM

Jan 7 2018

gottfried committed R336:a7fe6b3ee00c: Port Trainingscreen QCC 2.2 (authored by gottfried).
Port Trainingscreen QCC 2.2
Jan 7 2018, 5:05 PM

Jan 2 2018

gottfried committed R336:fad475f27eef: Qt 5.10 Compatability: Course Selector (authored by gottfried).
Qt 5.10 Compatability: Course Selector
Jan 2 2018, 7:17 PM
gottfried committed R336:85d92be30f19: Qt 5.10 Compatability: Rename `icon` Property (authored by gottfried).
Qt 5.10 Compatability: Rename `icon` Property
Jan 2 2018, 7:17 PM
gottfried committed R336:8b868c7d54b0: Homescreen: More Keyboard Focus Handling (authored by gottfried).
Homescreen: More Keyboard Focus Handling
Jan 2 2018, 7:17 PM

Dec 21 2017

gottfried accepted D9436: Add missing types to qmldir.

Thanks for the patch!

Dec 21 2017, 1:38 PM · KDE Edu
gottfried requested changes to D9436: Add missing types to qmldir.

Please add internal qualifiers.

Dec 21 2017, 1:23 PM · KDE Edu
gottfried reopened D9436: Add missing types to qmldir.

As @fvogt has already noticed, Label and LineLabel are not part of the public API. Please add the internal qualifier to added types.

Dec 21 2017, 1:21 PM · KDE Edu

Dec 14 2017

gottfried committed R336:3b234665cf3e: Profile Details: Fix Total Training Duration (authored by gottfried).
Profile Details: Fix Total Training Duration
Dec 14 2017, 10:48 PM
gottfried committed R336:1fa153e1ba03: Implement a Wrapper For `ComboBox` (authored by gottfried).
Implement a Wrapper For `ComboBox`
Dec 14 2017, 10:48 PM
gottfried committed R336:3bb8240323e9: Implement a Wrapper For `ScrollView` (authored by gottfried).
Implement a Wrapper For `ScrollView`
Dec 14 2017, 10:48 PM
gottfried committed R336:0ce3fe800dcc: Implement a Wrapper For `ToolTip` (authored by gottfried).
Implement a Wrapper For `ToolTip`
Dec 14 2017, 10:48 PM

Dec 12 2017

gottfried committed R336:e1c74700d08a: Clean up QML Imports (authored by gottfried).
Clean up QML Imports
Dec 12 2017, 8:29 PM
gottfried committed R336:4cc087e93bc8: Implement a Wrapper For `Toolbar` (authored by gottfried).
Implement a Wrapper For `Toolbar`
Dec 12 2017, 8:14 PM
gottfried committed R336:9689b4512447: Scroll Bar: Remove Stray Import (authored by gottfried).
Scroll Bar: Remove Stray Import
Dec 12 2017, 8:14 PM
gottfried committed R336:416272e99091: Implement a Wrapper For `QIconItem` (authored by gottfried).
Implement a Wrapper For `QIconItem`
Dec 12 2017, 8:14 PM
gottfried committed R336:4a0e83fb81fc: Retire `SheetDialog` (authored by gottfried).
Retire `SheetDialog`
Dec 12 2017, 8:14 PM
gottfried committed R336:5930ef4d8467: Enable Tab Navigation For List Views (authored by gottfried).
Enable Tab Navigation For List Views
Dec 12 2017, 8:14 PM

Dec 11 2017

gottfried committed R336:5ed8e208d590: Implement Wrapper for `ScrollBar` (authored by gottfried).
Implement Wrapper for `ScrollBar`
Dec 11 2017, 6:01 PM
gottfried committed R336:1dddb202c89d: Normalize QtQuick Imports (authored by gottfried).
Normalize QtQuick Imports
Dec 11 2017, 6:01 PM
gottfried committed R336:b2bb569e0107: Implement Wrapper for `GridView` (authored by gottfried).
Implement Wrapper for `GridView`
Dec 11 2017, 6:01 PM
gottfried committed R336:1511f80848df: List View: Use Scroll Bar instead of Indicator (authored by gottfried).
List View: Use Scroll Bar instead of Indicator
Dec 11 2017, 6:01 PM