gottfried (Sebastian Gottfried)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 4:07 PM (230 w, 1 d)
Availability
Available

Recent Activity

Thu, Aug 22

gottfried committed R336:500f7d373df2: Update README (authored by gottfried).
Update README
Thu, Aug 22, 10:09 AM

Aug 14 2019

gottfried committed R234:378c9248445e: Crop Screenshots (authored by gottfried).
Crop Screenshots
Aug 14 2019, 8:05 AM

Aug 13 2019

gottfried committed R234:4c57044a30be: New Screenshots for KTouch (authored by gottfried).
New Screenshots for KTouch
Aug 13 2019, 2:49 PM
gottfried abandoned D23113: Make the Balloon widther to prevent line breaks.
Aug 13 2019, 1:03 PM · KDE Edu
gottfried commandeered D23113: Make the Balloon widther to prevent line breaks.
Aug 13 2019, 1:03 PM · KDE Edu

Aug 12 2019

gottfried added a comment to D23113: Make the Balloon widther to prevent line breaks.

Thanks again, I have already pushed you original suggestions, see https://github.com/KDE/ktouch/commit/799d2d1a1619caef5787b91a5cbb92a1dd8d6b7a

Aug 12 2019, 4:27 PM · KDE Edu
gottfried committed R336:ed4d4181f320: Merge Branch 'Applications/19.08' (authored by gottfried).
Merge Branch 'Applications/19.08'
Aug 12 2019, 4:24 PM
gottfried committed R336:799d2d1a1619: Fix Tooltip Dimensions of Learning Progress Chart (authored by gottfried).
Fix Tooltip Dimensions of Learning Progress Chart
Aug 12 2019, 4:21 PM
gottfried committed R336:23a4623c24b2: Fix Visual Glitches in Dark Themes (authored by gottfried).
Fix Visual Glitches in Dark Themes
Aug 12 2019, 4:21 PM
gottfried closed D23048: Fix visual glitches in dark themes.
Aug 12 2019, 4:21 PM · VDG, KDE Edu
gottfried added a comment to D23048: Fix visual glitches in dark themes.

This (and the changes here) should go into the Applications/19.08 branch

I'm new to contribute to KDE. Is this done automatically or I need to do something else?

With Phabricator, an automatic merge is not possible, unfortunately. It can only do code review.

Aug 12 2019, 4:12 PM · VDG, KDE Edu
gottfried accepted D23048: Fix visual glitches in dark themes.

Thanks for the update!

Aug 12 2019, 2:43 PM · VDG, KDE Edu
gottfried requested changes to D23048: Fix visual glitches in dark themes.
Aug 12 2019, 11:54 AM · VDG, KDE Edu

Aug 8 2019

gottfried committed R336:8a8ffbc314de: Merge Branch 'Applications/19.08' (authored by gottfried).
Merge Branch 'Applications/19.08'
Aug 8 2019, 6:37 AM
gottfried committed R336:3abfd72454f3: Fix Fuzzy Icons on HiDPI Displays (authored by gottfried).
Fix Fuzzy Icons on HiDPI Displays
Aug 8 2019, 6:36 AM

Aug 7 2019

gottfried accepted D22990: Fix build with older cmake.
Aug 7 2019, 3:08 PM · KDE Applications, KDE Edu
gottfried accepted D22910: Replace obsolete QSignalMapper and qSort with non-obsolete code.

Sorry for the long wait. I discovered a crash in the keyboard layout editor which I suspected to be related to you work, but it is not. Still, I wanted to figure this out first.

Aug 7 2019, 6:30 AM · KDE Edu

Aug 6 2019

gottfried added a comment to D22910: Replace obsolete QSignalMapper and qSort with non-obsolete code.

I found two more spots which leak connections over time. These should be fixed.

Aug 6 2019, 6:56 AM · KDE Edu

Aug 5 2019

gottfried requested changes to D22910: Replace obsolete QSignalMapper and qSort with non-obsolete code.

Looks mostly good and works as intended. But its seems you have missed the member declarations and include directives:

Aug 5 2019, 8:29 AM · KDE Edu

Aug 3 2019

gottfried committed R336:a10031aaf915: Update README (authored by gottfried).
Update README
Aug 3 2019, 12:40 PM
gottfried committed R336:9f4c696fd97d: README: Fix URL of Embedded Build Status Badge (authored by gottfried).
README: Fix URL of Embedded Build Status Badge
Aug 3 2019, 12:30 PM
gottfried committed R336:1e7898917f0d: Home Screen: Uniform Spacing for Lesson Selector (authored by gottfried).
Home Screen: Uniform Spacing for Lesson Selector
Aug 3 2019, 12:30 PM
gottfried committed R336:3d8763b365dc: Monochrome Icon: Fix Default Size (authored by gottfried).
Monochrome Icon: Fix Default Size
Aug 3 2019, 12:30 PM

Jul 16 2019

gottfried committed R336:66242fe784ca: Merge Branch 'Applications/19.08' (authored by gottfried).
Merge Branch 'Applications/19.08'
Jul 16 2019, 7:10 PM
gottfried committed R336:bea9d4df88ca: Add a Simple Build Script (authored by gottfried).
Add a Simple Build Script
Jul 16 2019, 7:06 PM
gottfried committed R336:a3a7bf9d466c: Build w/o X11: Better Course Selection UI (authored by gottfried).
Build w/o X11: Better Course Selection UI
Jul 16 2019, 7:06 PM

Jul 14 2019

gottfried accepted D22389: Make Qt5X11Extras optional.

Good to go.

Jul 14 2019, 8:22 AM · KDE Edu

Jul 13 2019

gottfried committed R336:5427e1870ff4: Build w/o X11: Remove Keyboard Layout Menu (authored by gottfried).
Build w/o X11: Remove Keyboard Layout Menu
Jul 13 2019, 11:47 AM

Jul 11 2019

gottfried added inline comments to D22389: Make Qt5X11Extras optional.
Jul 11 2019, 7:02 AM · KDE Edu
gottfried requested changes to D22389: Make Qt5X11Extras optional.

Thanks for the patch. If you change the dependencies in the CMake files, you also need to update the README so they stay in sync.

Jul 11 2019, 6:28 AM · KDE Edu

Jul 10 2019

gottfried added a comment to D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.

Okay then... I do have commit access, fyi.

Jul 10 2019, 8:40 PM · KDE Edu
gottfried added a comment to D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.

I took your patch and fixed the remaining issues. I think, this review can be closed now.

Jul 10 2019, 7:51 PM · KDE Edu
gottfried committed R336:56ec6f23e9c4: Set a CMake Policy Version (authored by gottfried).
Set a CMake Policy Version
Jul 10 2019, 7:47 PM
gottfried committed R336:4cba35d316e0: Fix Build Without X11 Deps (authored by gottfried).
Fix Build Without X11 Deps
Jul 10 2019, 7:47 PM
gottfried committed R336:9726ef8fc020: README: Fix Instructions to Install Dependencies (authored by gottfried).
README: Fix Instructions to Install Dependencies
Jul 10 2019, 7:47 PM
gottfried committed R336:83186d9f8c04: Home Screen: Improve Wording (authored by gottfried).
Home Screen: Improve Wording
Jul 10 2019, 7:47 PM

Jul 9 2019

gottfried added a comment to D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.

@gottfried any reason you removed kde edu from the list of subscribers?

Jul 9 2019, 6:17 AM · KDE Edu

Jul 8 2019

gottfried committed R336:45abc5feef1e: Score Screen: Fix Display of Error Chart (authored by gottfried).
Score Screen: Fix Display of Error Chart
Jul 8 2019, 7:02 PM
gottfried edited reviewers for D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition, added: gottfried; removed: KDE Edu.
Jul 8 2019, 7:38 AM · KDE Edu

Jul 4 2019

gottfried committed R336:106d3bbe7725: Merge Branch 'homescreen-ng' (authored by gottfried).
Merge Branch 'homescreen-ng'
Jul 4 2019, 9:06 PM
gottfried closed D20953: New Home Screen for KTouch.
Jul 4 2019, 9:06 PM · KDE Edu
gottfried committed R336:ae2b5d6396c2: Merge Branch 'Applications/19.04' (authored by gottfried).
Merge Branch 'Applications/19.04'
Jul 4 2019, 6:54 AM
gottfried committed R336:032067dc63c3: Fix Chart Legend Visibility with Dark Color Scheme (authored by gottfried).
Fix Chart Legend Visibility with Dark Color Scheme
Jul 4 2019, 6:52 AM

Jun 27 2019

gottfried added a comment to D20953: New Home Screen for KTouch.

If no one objects within a week, I am going the merge this.

Jun 27 2019, 3:24 PM · KDE Edu
gottfried committed R336:7eede2ae198c: Merge Branch 'Applications/19.04' (authored by gottfried).
Merge Branch 'Applications/19.04'
Jun 27 2019, 3:06 PM
gottfried committed R336:2114304bfaf3: Fix Dimensions of Key Hints During Training (authored by gottfried).
Fix Dimensions of Key Hints During Training
Jun 27 2019, 3:05 PM
gottfried committed R336:9063b5de23e9: Fix Key Item Scaling Issues (authored by gottfried).
Fix Key Item Scaling Issues
Jun 27 2019, 3:05 PM

Jun 21 2019

gottfried committed R336:6e9e5feb7989: Merge Branch 'Applications/19.04' (authored by gottfried).
Merge Branch 'Applications/19.04'
Jun 21 2019, 11:38 AM
gottfried committed R336:1c55e2016ded: Fix Layout of Infomation Tables (authored by gottfried).
Fix Layout of Infomation Tables
Jun 21 2019, 11:36 AM

Jun 20 2019

gottfried committed R336:d8a8882dae75: Fix Crash when Closing Resource Editor (authored by gottfried).
Fix Crash when Closing Resource Editor
Jun 20 2019, 7:35 AM

Jun 19 2019

gottfried committed R336:0ad223458ca9: Fix Crash when Closing Resource Editor (authored by gottfried).
Fix Crash when Closing Resource Editor
Jun 19 2019, 2:50 PM

Jun 17 2019

gottfried added a comment to D20953: New Home Screen for KTouch.

There's a few relative scary warnings though

qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:367:25: QML LearningProgressChart: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:286:21: QML Label: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:293:21: QML ComboBox: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:306:21: QML Label: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:316:21: QML ComboBox: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:337:21: QML LegendItem: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:345:21: QML LegendItem: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:162:17: QML IconToolButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/ktouch/qml/homescreen/ProfileSelector.qml:90: TypeError: Cannot read property 'isNewButton' of null

have you seen this?

I don't see the layout warnings. Maybe you Qt is more recent than mine. Nonetheless, they should all be fixed now.

Jun 17 2019, 9:22 PM · KDE Edu
gottfried updated the diff for D20953: New Home Screen for KTouch.

Fix QML runtime warnings.

Jun 17 2019, 9:22 PM · KDE Edu
gottfried committed R336:8b46599242b5: Scorescreen: Fix Warnings wrt Anchors with Layouts (authored by gottfried).
Scorescreen: Fix Warnings wrt Anchors with Layouts
Jun 17 2019, 9:18 PM
gottfried committed R336:7e5a468c691b: Profile Selector: Fix Runtime Error (authored by gottfried).
Profile Selector: Fix Runtime Error
Jun 17 2019, 9:18 PM

May 4 2019

gottfried committed R336:a44f36def494: Load QML Resources from 'ktouch' Prefix (authored by gottfried).
Load QML Resources from 'ktouch' Prefix
May 4 2019, 1:31 PM
gottfried committed R336:5302229ab635: Provide @2x Images for HiDPI Rendering (authored by gottfried).
Provide @2x Images for HiDPI Rendering
May 4 2019, 1:31 PM
gottfried committed R336:caa71318f3a2: Remove Home Baked Image Lookup (authored by gottfried).
Remove Home Baked Image Lookup
May 4 2019, 1:31 PM
gottfried added a comment to D20953: New Home Screen for KTouch.

Hi, not a KTouch dev, but I found a typo. ;)

Yay, I'm basically the only one developing features for KTouch. I still value review for non-trivial changes, though.

:) So I tried it on my machine on it worked very well. :) Can't really comment about the code but found the sidebar shadow a bit strange. The shadow gave me the wrong impression that the sidebar is collapsible. Maybe you could ask the VDG for feedback. Otherwise, the UI looks great.

Thank you. I can see your point. I have added the shadow as visual separator between the sidebar and the lesson grid. I agree its a bit misleading. Maybe the VDG has a better idea.

May 4 2019, 1:13 PM · KDE Edu

May 2 2019

gottfried added a comment to D20953: New Home Screen for KTouch.

Hi, not a KTouch dev, but I found a typo. ;)

Yay, I'm basically the only one developing features for KTouch. I still value review for non-trivial changes, though.

May 2 2019, 8:32 PM · KDE Edu
gottfried updated the diff for D20953: New Home Screen for KTouch.

Fix Typo in checkqmlimports.py

May 2 2019, 8:29 PM · KDE Edu
gottfried committed R336:a6d3d61c88c3: checkqmlimports.py: Fix Typo (authored by gottfried).
checkqmlimports.py: Fix Typo
May 2 2019, 8:26 PM
gottfried requested review of D20953: New Home Screen for KTouch.
May 2 2019, 9:27 AM · KDE Edu

Apr 28 2019

gottfried committed R336:35058b4198b9: Merge Branch 'master' Into 'homescreen-ng' (authored by gottfried).
Merge Branch 'master' Into 'homescreen-ng'
Apr 28 2019, 3:45 PM
gottfried accepted D20861: Make QML compilation optional.

Works as advertised.

Apr 28 2019, 3:34 PM · KDE Edu

Apr 11 2019

gottfried committed R336:c85605d8aa63: Eliminate Call to Deprecated Method (authored by gottfried).
Eliminate Call to Deprecated Method
Apr 11 2019, 5:47 PM
gottfried committed R336:ee5ec3346ecc: Fix All Compiler Warnings (authored by gottfried).
Fix All Compiler Warnings
Apr 11 2019, 5:47 PM
gottfried committed R336:f601057305fb: Fix Layout of Infomation Tables (authored by gottfried).
Fix Layout of Infomation Tables
Apr 11 2019, 5:47 PM
gottfried committed R336:76a6584faab8: Fix Title Case Issue (authored by gottfried).
Fix Title Case Issue
Apr 11 2019, 5:47 PM
gottfried committed R336:7ac2b7dd3f53: Fix TextArea Background (authored by gottfried).
Fix TextArea Background
Apr 11 2019, 5:47 PM

Mar 9 2019

gottfried committed R336:435a041a0364: Fix Crash in Lesson Selector (authored by gottfried).
Fix Crash in Lesson Selector
Mar 9 2019, 6:00 PM
gottfried committed R336:f6dbef90518c: Merge Branch 'master' into 'homescreen-ng' (authored by gottfried).
Merge Branch 'master' into 'homescreen-ng'
Mar 9 2019, 6:00 PM
gottfried committed R336:fc01b9b147cf: Fix Build Because of Missing Include (authored by gottfried).
Fix Build Because of Missing Include
Mar 9 2019, 6:00 PM

Feb 24 2019

gottfried committed R336:d9b49c523576: Update Basque Course (authored by gottfried).
Update Basque Course
Feb 24 2019, 3:48 PM
gottfried committed R336:3d978a90b06e: Update it2 Course (authored by gottfried).
Update it2 Course
Feb 24 2019, 3:48 PM
gottfried closed D18902: Fix it2 course.

I have pushed the changes to the KTouch Git repository.

Feb 24 2019, 3:41 PM · KDE Edu
gottfried accepted D18902: Fix it2 course.
Feb 24 2019, 3:39 PM · KDE Edu

Feb 16 2019

gottfried requested changes to D18902: Fix it2 course.

Hi Simone,

Feb 16 2019, 3:07 PM · KDE Edu

Jan 2 2019

gottfried committed R336:8598e4af1054: Add New Italian Course (authored by gottfried).
Add New Italian Course
Jan 2 2019, 7:34 PM
gottfried added a comment to D17914: Add improved lesson for Italian.

I have added your course to KTouch, see https://cgit.kde.org/ktouch.git/commit/?id=8598e4af105418a92d54f5dbfbbaf04be9a492d7. It will be part of the upcoming 18.04 release.

Jan 2 2019, 6:52 PM · KDE Edu
gottfried abandoned D17926: Add course as additional course..
Jan 2 2019, 6:45 PM · KDE Edu
gottfried added a dependent revision for D17914: Add improved lesson for Italian: D17926: Add course as additional course..
Jan 2 2019, 6:44 PM · KDE Edu
gottfried added a dependency for D17926: Add course as additional course.: D17914: Add improved lesson for Italian.
Jan 2 2019, 6:44 PM · KDE Edu
gottfried requested review of D17926: Add course as additional course..
Jan 2 2019, 6:43 PM · KDE Edu
gottfried added a comment to D17914: Add improved lesson for Italian.

Alright, I will wait.

Jan 2 2019, 3:51 PM · KDE Edu
gottfried requested changes to D17914: Add improved lesson for Italian.

Hi Simone,

Jan 2 2019, 1:30 PM · KDE Edu

Sep 4 2018

gottfried committed R336:07a95f1dfc97: Add New Italian Course and Update Keyboard Layout (authored by gottfried).
Add New Italian Course and Update Keyboard Layout
Sep 4 2018, 7:38 PM

May 17 2018

gottfried committed R336:7003d4208108: Extend README (authored by gottfried).
Extend README
May 17 2018, 8:45 PM
gottfried committed R336:989fb6dc5e19: Remove Commented Code (authored by gottfried).
Remove Commented Code
May 17 2018, 8:45 PM

May 3 2018

gottfried committed R336:919f8403f706: Learning Progess Charts: Show Training Dates (authored by gottfried).
Learning Progess Charts: Show Training Dates
May 3 2018, 4:26 PM
gottfried committed R336:e5fa58b5776f: Add Focus Indicator for Grid View (authored by gottfried).
Add Focus Indicator for Grid View
May 3 2018, 4:26 PM
gottfried committed R336:450d75d35149: Profile Selector: Tweak Layout (authored by gottfried).
Profile Selector: Tweak Layout
May 3 2018, 3:29 PM
gottfried committed R336:8a8729399b98: Fix Label in Profile Form (authored by gottfried).
Fix Label in Profile Form
May 3 2018, 3:29 PM
gottfried committed R336:d5049fc4a0d1: Learning Progess Charts: Embed Tooltips (authored by gottfried).
Learning Progess Charts: Embed Tooltips
May 3 2018, 3:29 PM
gottfried committed R336:78d9ba87455a: Key Item: Fix Shadow Appearance (authored by gottfried).
Key Item: Fix Shadow Appearance
May 3 2018, 3:29 PM
gottfried committed R336:0b4652e05393: Score Screen: Tweak Margins of Toolbar (authored by gottfried).
Score Screen: Tweak Margins of Toolbar
May 3 2018, 3:29 PM

Apr 18 2018

gottfried committed R954:a93f0bdebcb8: Update My Feed URL (authored by gottfried).
Update My Feed URL
Apr 18 2018, 1:17 PM

Mar 19 2018

gottfried accepted D11473: course de1. corrections 'Übung 2'.
Mar 19 2018, 8:03 AM · KDE Edu

Mar 17 2018

gottfried accepted D11401: Corrections course de1.

Thanks for the patch 😀

Mar 17 2018, 9:46 AM · KDE Edu
gottfried requested changes to D11401: Corrections course de1.
Mar 17 2018, 8:01 AM · KDE Edu