Now we request a bunch, then check if there are enough and request more until there is

@vikasd We have done this one at the KDE Connect sprint. Check it out!

It needs the dependency on qt5-quickcontrols2

This can be re-opened when we want to look at this feature again, but I'm closing for now

@jdvr Are you still interested in working on this? We would need some flow to request the permission on newer Android versions. With the runtime permissions, it seems like it would make the most sense to ask for this as soon as the user brings up the settings panel for configuring trusted networks.

In D22427#494773, @skumblex wrote:

Hi sredman.

Thanks for the information. I did not know that there is a dedicated localization team, but I will contact them as soon as possible. Then, I guess you can close this review request.

Hi skumblex. Thank you very much for taking the time to do this!

In D21589#494068, @Petross404 wrote:

In D21589#492408, @sredman wrote:

Actually, there is a bit of a problem... The version of the file currently on master is bugged :(

See: https://phabricator.kde.org/D17908#492404

Any progress with the MS tool?

Actually, a pleasant surprise for today is that this whole mess of registry keys and environment variables is mostly unnecessary as of VS 2017, since Microsoft provides a tool which does all the locating work for us: https://github.com/microsoft/vswhere

Actually, there is a bit of a problem... The version of the file currently on master is bugged :(

Unfortunately, I have a problem with using the batch file from this diff on my system.

In D21589#492284, @kossebau wrote:

Ping? Please keep hammering the iron while hot :)

Has this been landed yet? Is there any reason to keep it open?

In D21589#477664, @Petross404 wrote:

brauch is referring to this

for /f "usebackq tokens=3*" %%a in (`reg query "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7" /s`) do (
     set vs15_path=%%a %%b
     if exist "!vs15_path!Common7\Tools\VsDevCmd.bat" (
	set "VS150COMNTOOLS=!vs15_path!Common7\Tools\"
	goto :end
     )
   )
)
:end

Oops. What happened here is I was hacking on the release version which looks more like the patch I posted. I'll see if I can make sense of the master branch version and make it more like that!

In D21589#477604, @brauch wrote:

Why did you replace the registry query by a fixed path?

In D21661#476571, @pino wrote:

In D21661#476156, @pino wrote:

how is snoretoast actually used here? you are requiring the library for building and linking, but then:

• snoretoastactions.h, which is part of the headers of snoretoast, is copied here
• the snoretoast library is never used, as the utilities of it are invoked instead If the library does all the work already, then I'd prefer to use it directly instead of spawning executables all the time...

Piyush, what about this? It seems the snoretoast library provides a SnoreToasts class to do this instead of spawning an helper tool, what about using it instead?

The only thing I immediately see as a problem is the uninstaller doesn't have the proper branding (generic icons), and it didn't uninstall the desktop shortcut

Appears to be fixed by commit 9447d7e5def9f3a2d2bcaab10e7b646faaf041a3

On hold until ~July 19

In D21369#469389, @apol wrote:

Seems like a clear layer break to spill KContacts over KPeople :P.
Let's discuss it at the sprint? Or earlier. Let's discuss it? ^^'

• Hack on QMetaType support

• Add link_library target to backends as well

• Move KF5::Contacts to PUBLIC library

In D21353#468804, @apol wrote:

How would you pass more information? in a QVariantMap?

Also, it looks like KContact::PhoneNumber is set up such that it could be used as a QVariant. From my point of view, the additional information in the PhoneNumber object would be useful so I could display something like "Simon Redman (Mobile)" or "Simon Redman (Home)" in case of multiple matches.

Remove line about KDE Framework

Apologies if this is already covered. I haven't looked deeply at the source materials in the very early links.

It would be good to commit the above changes back to Kaidan when we have it working nicely, since the message composition box originally came from them.