Awesome, k, I nuked my branch when I modified it. I'll just push the commit on the 5.0 branch and close this revision, makes sense.

Wow, so looking forward to gitlab. So after a revision has been accepted what's the preferred way to land it? merge? cherry-pick? just rebase on the 5.0 branch and push?

Changed logic to match review comments.

I'm open to having this option also hide asset accounts with zero balance, though that might be better as a separate option. Personally I'd like to continue to see my zero balance assets to be reminded I need to put something in them at some point (or close them if they are not being useful, etc.)

Looks good to me. Thanks for doing that fix.

Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting the url with the KUrlComboBox we give to the KUrlRequester via it's setUrl method. Looking at KUrlComboBox::setUrl it's blocking signals in the body of setUrl and since we are not connecting to the QLineEdit anymore we never get that signal.

Looks good to me. thanks again.

Looks good to me except for the flite bits. I'll go remind my self how to tell QtSpeech to use the flite backend/plugin, but it's definitely optional.

Looks good to me. Thank you for taking this on.

Yes, this should go in the frameworks branch, I'll see if I can get the frameworks branch merged to master this week.

Hmm QScreen::grabWindow is already grabbing pixmap data from both screens here. I wonder why it needs the QScreen object at all. At any rate it seems to work fine.

Looks like this is already in kmag master. I'll see if I can sort out how to decide which screen to grab from.

Seems to be gone. Can we close this?

I like it. Nice work. I agree I would change Config Scheme to Edit Scheme.

Looks good to me.

Qt 5.6 actually doesn't include QtTextToSpeech, it will be in Qt 5.7 instead as tech preview apparently :/

QtTextToSpeech hasn't been released yet, but will be part of Qt 5.6 when it comes out.

Thanks to Sayan it's all done.