Jul 22 2019
Jun 18 2019
Awesome, k, I nuked my branch when I modified it. I'll just push the commit on the 5.0 branch and close this revision, makes sense.
Wow, so looking forward to gitlab. So after a revision has been accepted what's the preferred way to land it? merge? cherry-pick? just rebase on the 5.0 branch and push?
Jun 16 2019
Changed logic to match review comments.
I'm open to having this option also hide asset accounts with zero balance, though that might be better as a separate option. Personally I'd like to continue to see my zero balance assets to be reminded I need to put something in them at some point (or close them if they are not being useful, etc.)
Apr 11 2019
Mar 26 2019
Mar 20 2019
Sep 13 2018
Looks good to me. Thanks for doing that fix.
Feb 14 2018
Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting the url with the KUrlComboBox we give to the KUrlRequester via it's setUrl method. Looking at KUrlComboBox::setUrl it's blocking signals in the body of setUrl and since we are not connecting to the QLineEdit anymore we never get that signal.
Jan 7 2018
Looks good to me. thanks again.
Jan 5 2018
Looks good to me except for the flite bits. I'll go remind my self how to tell QtSpeech to use the flite backend/plugin, but it's definitely optional.
Looks good to me. Thank you for taking this on.
Oct 24 2017
Aug 8 2017
Jul 5 2017
Jun 25 2017
Yes, this should go in the frameworks branch, I'll see if I can get the frameworks branch merged to master this week.
May 12 2017
Hmm QScreen::grabWindow is already grabbing pixmap data from both screens here. I wonder why it needs the QScreen object at all. At any rate it seems to work fine.
Looks like this is already in kmag master. I'll see if I can sort out how to decide which screen to grab from.
May 2 2017
May 1 2017
Apr 19 2017
Apr 18 2017
Sep 10 2016
Sep 2 2016
Seems to be gone. Can we close this?
Aug 11 2016
I like it. Nice work. I agree I would change Config Scheme to Edit Scheme.
May 31 2016
Looks good to me.
Apr 16 2016
Qt 5.6 actually doesn't include QtTextToSpeech, it will be in Qt 5.7 instead as tech preview apparently :/
Jan 5 2016
Dec 14 2015
QtTextToSpeech hasn't been released yet, but will be part of Qt 5.6 when it comes out.
Sep 17 2015
Sep 15 2015
Sep 12 2015
Thanks to Sayan it's all done.