so we have Jenkins ready to build .Appx packages for us now, thanks to @bcooksley : https://invent.kde.org/sysadmin/binary-factory-tooling/commit/aeddc47b0ca4dcdef64044226b99d9b78a0156a7

updated

took inspiration from NotifyByAndroid. Now I can see all types of notifications perfectly well!

the duplicate notification always has id= -1, so I think it's more an issue of KNotifications, I think

In D21661#510813, @vkrause wrote:

It looks like this made D-Bus and Phonon hard required dependencies on Android again!?

In D22727#505540, @dfaure wrote:

The Qt documentation says "Warning: Because of differences in the platforms supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are platform-dependent: On Unix, the rights of the owner of the file are returned and on Windows the rights of the current user are returned. "

removed duplication

rebased.

landing this one. 🎉

done.

waiting for some green light(s) for now...

• removed the duplicate remover.

landing it...

Please do a last minute review, I believe this patch is ready to merge now. 🎉

In D22727#501824, @vonreth wrote:

Looks good.
Why not the first time 😊

let's put a pin in this for a while until I get a better solution for DBus on Windows

got it 😥🔫

nvm, I'll try to find a better solution instead.

sorry about that. I'll find a better solution that doesn't break builds 🙈

For KStatusNotifierItem, KDE Connect uses QSystemTrayIcon on windows. See https://github.com/KDE/kdeconnect-kde/blob/master/indicator/main.cpp#L169

?

updated and rebased.

thanks Hannah!

ah, I did not see that patch. No use of this one now. 😺

:p

I'll not leave it like this from next time, that's for sure. :p

should've removed WIP before landing 😬

yeah I can push! I'm a GSoCer lol

updated!

updated

updated

updated

updated

In D22554#497984, @nicolasfella wrote:

Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case

updated

updated wrt new comments. @dfaure please take another look! 👀

landing it

updated