avoid duplicate notifications from showing up on Windows and remove whitespaces
ClosedPublic

Authored by brute4s99 on Tue, Aug 13, 6:47 PM.

Details

Summary

without this patch, most notifications show every notification twice. This seems to be an internal problem of knotification, but until that is fixed, this is the next best solution IMHO.

Test Plan

without this patch, every mobile notification from KDE Connect should show up twice.

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
brute4s99 created this revision.Tue, Aug 13, 6:47 PM
Restricted Application added a project: Frameworks. ยท View Herald TranscriptTue, Aug 13, 6:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. ยท View Herald Transcript
brute4s99 requested review of this revision.Tue, Aug 13, 6:47 PM

I think this is a bug in KDE Connect? I've seen numerous people complain about that in the new notification system that didn't filter them out originally.

the duplicate notification always has id= -1, so I think it's more an issue of KNotifications, I think

Then please investigate what's going on there.

brute4s99 updated this revision to Diff 63846.Fri, Aug 16, 2:35 AM

took inspiration from NotifyByAndroid. Now I can see all types of notifications perfectly well!

can I merge this one? ๐Ÿ‘€

broulik accepted this revision.Tue, Aug 20, 1:37 PM
This revision is now accepted and ready to land.Tue, Aug 20, 1:37 PM

Just on Windows, or does this fix the problem on Linux too?

Just on Windows, or does this fix the problem on Linux too?

that problem has been fixed by @nicolasfella on master of kdeconnect-kde .

This bug was a backend specific issue of the windows build, unrelated to that bug. ๐Ÿ›

This revision was automatically updated to reflect the committed changes.