Create Task
Maniphest T11275

Compilation errors on Windows CI related to KStatusNotifierItem
Closed, ResolvedPublic
Actions

Description

A couple of days ago several applications started getting compilation errors in Windows CI, related to KF5Notifications' KStatusNotifierItem, see for example

There were no changes in the code in KTimeTracker at that period of time. Did CI configuration change and break something on July 21th?

Restricted Application added a subscriber: sysadmin. · View Herald TranscriptJul 22 2019, 11:32 PM
bcooksley added a subscriber: bcooksley.Jul 23 2019, 2:05 AM

This is probably a regression within KNotifications or ECM.

Please see https://build.kde.org/job/Administration/job/Dependency%20Build%20Extragear%20kf5-qt5%20WindowsMSVCQt5.11/65/ which completed a day or so after the last successful build of KTimeTracker, and would have provided the latest Frameworks/ECM to those projects.

bcooksley changed the visibility from "Custom Policy" to "Public (No Login Required)".Jul 23 2019, 2:05 AM
bcooksley changed the edit policy from "Custom Policy" to "All Users".

I've made this task publicly accessible in case you wish to refer to it within a mailing list posting.

aspotashev added a comment.Jul 23 2019, 2:34 AM

Thanks! Reported a regression in KNotifications: https://phabricator.kde.org/D21660#500579

brute4s99 added a subscriber: brute4s99.Jul 23 2019, 9:34 AM

For KStatusNotifierItem, KDE Connect uses QSystemTrayIcon on windows. See https://github.com/KDE/kdeconnect-kde/blob/master/indicator/main.cpp#L169

Is it possible to change KStatusNotifierItem to QSystemTrayIcon for other projects as well?

brute4s99 added a comment.Jul 23 2019, 9:42 AM

nvm, I'll try to find a better solution instead.

aspotashev closed this task as Resolved.Jul 23 2019, 11:06 PM
aspotashev claimed this task.

The guilty commit has been reverted in KNotifications, let's hope everything builds successfully on the next respin of Extragear environment.