Reworked, by reshuffling the dialog text, instead of renaming the buttons
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Dec 13 2018
Dec 13 2018
Dec 12 2018
Dec 12 2018
Will have to rework, I missed some cases(the dialog might as to activate. deactivate or "activate some, deactivate others"), it is not as simple as I thought.
amantia added a comment to D17536: Make accessibility warning dialog usable again and fix event handling.
Accessibility bugfixes cherry picked from master
amantia requested review of D17536: Make accessibility warning dialog usable again and fix event handling.
amantia added reviewers for D17533: Make the button's purpose more clear: Plasma Accessibility, davidedmundson, aacid.
Dec 11 2018
Dec 11 2018
Messed up a little and this got landed together with another patch https://cgit.kde.org/plasma-desktop.git/commit/?id=40b9e34ced6b421c8585f304d91a2da37f40c4d6
amantia committed R119:40b9e34ced6b: Make accessibility warning dialog usable again (authored by amantia).
Make accessibility warning dialog usable again
Dec 8 2018
Dec 8 2018
Added comment for workaround
Dec 7 2018
Dec 7 2018
amantia added reviewers for D17408: Make accessibility warning dialog usable again: Plasma Accessibility, Plasma, aacid.
Dec 3 2018
Dec 3 2018
Oct 9 2018
Oct 9 2018
Oct 6 2018
Oct 6 2018
Go ahead, I'm fine with the license change.
Mar 8 2018
Mar 8 2018
amantia committed R119:988ec87663b1: Merge remote-tracking branch 'origin/Plasma/5.12' (authored by amantia).
Merge remote-tracking branch 'origin/Plasma/5.12'
amantia committed R119:8f1ddca3cfca: Improve multi-desktop folderview behavior (authored by amantia).
Improve multi-desktop folderview behavior
Use QUrl in the ScreenMapper API
Moved to 5.12
Feb 28 2018
Feb 28 2018
I can't put to 5.12 as it seems https://phabricator.kde.org/D9325 didn't get into the 5.12 branch, and I don't want two versions of this patch. May I cherry-pick that commit to 5.12 and apply this patch?
amantia committed R119:07001277a8a0: Improve detecting D&D between two screen showing the same URL (authored by amantia).
Improve detecting D&D between two screen showing the same URL
Yes, I will push first to 5.12 both of them
It adds a new entry, doesn't change an existing one. If that is not there, I see no problems, the ScreenMapper::readDisabledScreensMap() will not initialize the m_itemsOnDisabledScreensMap. That map was not saved previously, thus the folderview behaving differently after a restart, as the map was lost.
Ping?
Ping?
Feb 21 2018
Feb 21 2018
amantia added reviewers for D10729: Improve detecting D&D between two screen showing the same URL: Plasma, hein, mwolff.
Feb 19 2018
Feb 19 2018
Merge branch 'Plasma/5.12'
amantia committed R119:65bbc75f3ad6: Disable positioning in popup folderviews (authored by amantia).
Disable positioning in popup folderviews
amantia committed R119:f5ed6fad0155: Add option to enable shared folderview content per desktop (authored by amantia).
Add option to enable shared folderview content per desktop
Feb 12 2018
Feb 12 2018
Add includes to build with Qt 5.11
Feb 10 2018
Feb 10 2018
Yes, I have commit access since some time. ;)
Feb 9 2018
Feb 9 2018
amantia added reviewers for D10408: Add option to enable shared folderview content per desktop: Plasma, hein.
Jan 26 2018
Jan 26 2018
Use QUrl in the ScreenMapper API
Jan 25 2018
Jan 25 2018
Make the code more clear, by renaming a local variable.
Jan 23 2018
Jan 23 2018
Change code according to reviewer's requests
Jan 6 2018
Jan 6 2018
Sorry about it.
Dec 22 2017
Dec 22 2017
amantia committed R119:38268a142ecf: Use ScreenMapper everywhere as a singleton (authored by amantia).
Use ScreenMapper everywhere as a singleton
Dec 18 2017
Dec 18 2017
Store screenMapping info only once
Dec 15 2017
Dec 15 2017
Fixed issues pointed out by Laurent.
I will merge this latest on Monday if there is no further objection
Dec 14 2017
Dec 14 2017
amantia committed R119:093cc5a63635: Don't move back items to second screen if they were manually moved (authored by amantia).
Don't move back items to second screen if they were manually moved
In D9300#179031, @broulik wrote:Screen mapper is a singleton type, so it won't cause problems when one screen adds a mapping, it will propagate to the other containments automagically? Before we had plasmoid.configuration which signals changes but C++ does not, obviously.
To be honest, I'm not sure the benefit of a nice API warrants the rest of the ugliness, as some parts still rely on using a string for URL (FolderModel::url) and makes the unit tests also uglier.
Connect to screenammper only if used as a containment
amantia added reviewers for D9323: Use ScreenMapper everywhere as a singleton: Plasma, mwolff, hein.
Dec 13 2017
Dec 13 2017
amantia added reviewers for D9313: Don't move back items to second screen if they were manually moved: Plasma, hein, mwolff.
amantia committed R119:4c977747bd90: Create new items at the position where the context menu was invoked (authored by amantia).
Create new items at the position where the context menu was invoked
amantia committed R119:b5985e459349: Show newly created items on the right desktop (authored by amantia).
Show newly created items on the right desktop
I think it is better to store once, than 2-3 times (per desktop) as the data is the same. I'm not sure if the corona level is the best, although I don't see big problems with it.
Add const
Dec 12 2017
Dec 12 2017
Nov 28 2017
Nov 28 2017
amantia committed R119:c0f8856742a4: Avoid jumping of items toward right/botton when dropping (authored by amantia).
Avoid jumping of items toward right/botton when dropping
amantia committed R119:98d56d9135b1: Update the proxy to source and source to proxy mapping correctly (authored by amantia).
Update the proxy to source and source to proxy mapping correctly
amantia committed R119:cc9c3d32a381: Support drag and drop between shared folder view containments (authored by mwolff).
Support drag and drop between shared folder view containments
Rebased
amantia committed R119:e94888701c32: FolderView: position files at drop event target position (authored by mwolff).
FolderView: position files at drop event target position
Make Folder View screen aware
Nov 27 2017
Nov 27 2017
@davidedmundson Any comments? If not, I will push this tomorrow.
Nov 24 2017
Nov 24 2017
Guard screenmapper usage
Nov 23 2017
Nov 23 2017
amantia added inline comments to D8850: Support drag and drop between shared folder view containments.
amantia added inline comments to D8850: Support drag and drop between shared folder view containments.
Guard m_screenMapper usage
Milian, please also update the commit description (the last paragraph needs to go away).