Until now every FolderView applet stored exactly the same screenMapping info in the config file. Store it only once
using the config object of the Plasma::Corona
Details
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
containments/desktop/plugins/folder/screenmapper.cpp | ||
---|---|---|
202 | const QStringList |
Are you sure @mart? Do we really want to store applet-specific (though not applet instance-specific) config at the corona level?
I think it is better to store once, than 2-3 times (per desktop) as the data is the same. I'm not sure if the corona level is the best, although I don't see big problems with it.
I'm totally on board with avoiding the redundant data for sure, just double-checking since it sets a precedent etc.
Screen mapper is a singleton type, so it won't cause problems when one screen adds a mapping, it will propagate to the other containments automagically? Before we had plasmoid.configuration which signals changes but C++ does not, obviously.
I'm not sure if that is a question for me or not. :) Due to being a singleton, I don't see a problem, all instances of the folderview see the same mapping.