Update the proxy to source and source to proxy mapping correctly
ClosedPublic

Authored by amantia on Nov 20 2017, 3:12 PM.

Details

Summary

The problem is visible when an item is moved to another screen and moved back.
When it is moved out, the proxy-source mapping changes (as the items
is filtered out from the underlining model), while when moved back, it is
changed again, but in a wrong way that breaks the mapping and results
in "losing" one mapping, thus one item disappears.
There is a unit test added for it.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amantia created this revision.Nov 20 2017, 3:12 PM
amantia set the repository for this revision to R120 Plasma Workspace.
amantia updated this revision to Diff 22665.Nov 20 2017, 3:46 PM

Add uniqueness testing for the maps

Restricted Application added a project: Plasma. · View Herald TranscriptNov 20 2017, 3:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mwolff accepted this revision.Nov 20 2017, 8:30 PM

lgtm, but @hein should have a look too

This revision is now accepted and ready to land.Nov 20 2017, 8:30 PM
hein accepted this revision.Nov 22 2017, 1:06 PM
This revision was automatically updated to reflect the committed changes.