Differential D8922

Avoid jumping of items toward right/botton when dropping
ClosedPublic
Actions

Authored by amantia on Nov 21 2017, 10:11 AM.

Details

Reviewers
hein
mwolff
Group Reviewers
Plasma
Commits
R119:c0f8856742a4: Avoid jumping of items toward right/botton when dropping

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amantia created this revision.Nov 21 2017, 10:11 AM
amantia added reviewers: Plasma, hein, mwolff.Nov 21 2017, 10:11 AM
amantia set the repository for this revision to R119 Plasma Desktop.
mwolff accepted this revision.Nov 22 2017, 9:45 AM

lgtm

This revision is now accepted and ready to land.Nov 22 2017, 9:45 AM
hein added a comment.Nov 23 2017, 11:57 AM

For conceptual sanity checking, could you look at c9a7741f2b8082f025b5eb2e53c3c489a95e1da8 and how these align? Note how that commit cares more about what the user considers the visual center (the icon) rather than cell or delegate centers.

Closed by commit R119:c0f8856742a4: Avoid jumping of items toward right/botton when dropping (authored by amantia). · Explain WhyNov 28 2017, 7:32 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 28 2017, 7:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein added a comment.Jan 6 2018, 1:27 AM

I'm going to revert this commit. It has made the DND experience very poor (icons jump around like crazy on drop). My review comment was ignored, and it went in after an accept by a developer who is not involved with Plasma development and doesn't maintain the codebase. This style of "we'll get code in by ACK'ing each other" is extremely poor form.

amantia added a comment.Jan 6 2018, 8:54 AM

Sorry about it.

Revision Contents
Changeset List

Diff 23068

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...