Differential D10407

Disable positioning in popup folderviews
ClosedPublic
Actions

Authored by amantia on Feb 9 2018, 4:33 PM.

Details

Reviewers
hein
Commits
R119:65bbc75f3ad6: Disable positioning in popup folderviews
Summary

We need to use the overriden sortMode, not the model's sort mode.
The == -> === changes are just cosmetic, not related to functionality

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
amantia created this revision.Feb 9 2018, 4:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 9 2018, 4:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
amantia requested review of this revision.Feb 9 2018, 4:33 PM
amantia added a reviewer: hein.Feb 9 2018, 4:34 PM
davidedmundson added a subscriber: davidedmundson.Feb 9 2018, 11:53 PM

Looks sensible. Do you have commit access?

amantia added a comment.Feb 10 2018, 1:08 PM

Yes, I have commit access since some time. ;)

hein accepted this revision.Feb 11 2018, 8:11 AM
This revision is now accepted and ready to land.Feb 11 2018, 8:11 AM
hein added a comment.Feb 11 2018, 8:12 AM

This should go into 5.12 and then be merged up.

amantia closed this revision.Feb 19 2018, 3:41 PM

Revision Contents
Changeset List

Diff 26824

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...
View Options

containments/desktop/package/contents/ui/FolderViewDialog.qml

Loading...